FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

GH-80486: Fix handling of NTFS alternate data streams in pathlib by barneygale · Pull Request #102454 · python/cpython · GitHub

/ cpython Public

GH-80486: Fix handling of NTFS alternate data streams in pathlib - #102454

Merged
zooba merged 12 commits into
python:mainfrom
barneygale:gh-80486-ntfs-alt-stream-path
Mar 10, 2023
ConversationCommits (12)ChecksFiles changed
Merged

GH-80486: Fix handling of NTFS alternate data streams in pathlib#102454
zooba merged 12 commits into
python:mainfrom
barneygale:gh-80486-ntfs-alt-stream-path

Conversation

barneygale commented Mar 6, 2023 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Contributor

This fixes round-tripping of Windows paths like ./c:a in pathlib.

Previously, pathlib removed the ./ prefix when generating a string representation of such paths. This changed the meaning, from a file in the current directory called "c" with an NTFS alternate data stream, to a relative path on the "c:" drive.

Most of the patch by @kmaork. I brought it up-to-date.

bedevere-bot mentioned this pull request Mar 6, 2023
Closed
barneygale changed the title GH-80486: Fix handling of NTFS alternate data streams GH-80486: Fix handling of NTFS alternate data streams in pathlib Mar 6, 2023

barneygale commented Mar 6, 2023

Copy link
Copy Markdown
Contributor Author

This won't backport as it relies on a number of internal changes in 3.12 only.

zooba reviewed Mar 6, 2023
View reviewed changes
Comment thread Lib/pathlib.py Outdated
eryksun reviewed Mar 6, 2023
View reviewed changes
Comment thread Lib/pathlib.py
barneygale mentioned this pull request Mar 7, 2023
Closed

zooba commented Mar 10, 2023

Copy link
Copy Markdown
Member

Are we going to wait for #102511 to be implemented? Or leave a note in that one to update this use when it's done?

As this issue is about correctness and the other is about performance, I'd prefer not to wait.

barneygale commented Mar 10, 2023

Copy link
Copy Markdown
Contributor Author

Personally I'd rather not wait! :)

zooba commented Mar 10, 2023

Copy link
Copy Markdown
Member

Feel free to merge (and backport as appropriate), then!

barneygale commented Mar 10, 2023

Copy link
Copy Markdown
Contributor Author

I'm not a core dev so I don't have any merge permissions I don't think! 😅

zooba commented Mar 10, 2023 •
edited
Loading

Copy link
Copy Markdown
Member

Oh aren't you? We should probably fix that 😉 (though I'm literally about to step away for the weekend, so next week)

barneygale commented Mar 10, 2023

Copy link
Copy Markdown
Contributor Author

(and unfortunately this won't backport due to other changes in 3.12 being required)

zooba merged commit 90f1d77 into python:main Mar 10, 2023
barneygale mentioned this pull request Mar 10, 2023
Closed
iritkatriel pushed a commit to iritkatriel/cpython that referenced this pull request Mar 12, 2023
pythonGH-80486: Fix handling of NTFS alternate data streams in pathlib (
5f49d2d 
pythonGH-102454)

Co-authored-by: Maor Kleinberger <kmaork@gmail.com>
barneygale mentioned this pull request Apr 20, 2023
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

eryksun eryksun left review comments
zooba zooba approved these changes

Assignees

No one assigned

Labels

OS-windows topic-pathlib

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

Back | FazBrowse Home | New Git URL