Repository navigation
gh-102304: Move the Total Refcount to PyInterpreterState - #102545
Merged
ericsnowcurrently merged 6 commits intoMar 21, 2023
Merged
ericsnowcurrently merged 6 commits into
ericsnowcurrently merged 6 commits into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
ericsnowcurrently
force-pushed
the
isolate-pyreftotal
branch
2 times, most recently
from
b3bb5e5 to
668eb4c
Compare
March 9, 2023 19:13
Copy link
Copy Markdown
Member
Author
|
FYI, I'm probably going to add some code to preserve the per-interpreter total when each subinterpreter is destroyed, so any leaks may be handled appropriately when the runtime is finalized. I may also report the per-interpreter total at interpreter finalization. We'll see. |
Sorry, something went wrong.
ericsnowcurrently
force-pushed
the
isolate-pyreftotal
branch
3 times, most recently
from
780e7ec to
68da9da
Compare
March 20, 2023 16:39
ericsnowcurrently
force-pushed
the
isolate-pyreftotal
branch
from
68da9da to
f64202d
Compare
March 20, 2023 18:06
ericsnowcurrently
marked this pull request as ready for review
March 20, 2023 19:17
Copy link
Copy Markdown
|
🤖 New build scheduled with the buildbot fleet by @ericsnowcurrently for commit 475db68 🤖 If you want to schedule another build, you need to add the 🔨 test-with-refleak-buildbots label again. |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
|
The refleak buildbots all look good. |
Sorry, something went wrong.
Fidget-Spinner
pushed a commit
to Fidget-Spinner/cpython
that referenced
this pull request
Mar 27, 2023
…ngh-102545) Moving it valuable with a per-interpreter GIL. However, it is also useful without one, since it allows us to identify refleaks within a single interpreter or where references are escaping an interpreter. This becomes more important as we move the obmalloc state to PyInterpreterState. python#102304
warsaw
pushed a commit
to warsaw/cpython
that referenced
this pull request
Apr 11, 2023
…ngh-102545) Moving it valuable with a per-interpreter GIL. However, it is also useful without one, since it allows us to identify refleaks within a single interpreter or where references are escaping an interpreter. This becomes more important as we move the obmalloc state to PyInterpreterState. python#102304
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moving it valuable with a per-interpreter GIL. However, it is also useful without one, since it allows us to identify refleaks within a single interpreter or where references are escaping an interpreter. This becomes more important as we move the obmalloc state to PyInterpreterState.
(This PR is basically a single commit on top of gh-102543.)