bpo-35081: Move _PyObject_GC_TRACK() to pycore_object.h - #10276
Closed
vstinner wants to merge 1 commit into
Closed
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
Without that, at least 33 C files has to be modified to add include pycore_object.h: see my first attempt, PR #10272. I prefer to have smaller PR, easier to review. The automatic include can be removed later. |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
|
Note for myself: PR #10275 has to be updated if this PR is merged before. |
Sorry, something went wrong.
* Create Include/internal/pycore_object.h * Move _PyObject_GC_TRACK() and _PyObject_GC_UNTRACK() macros to pycore_object.h * Remove _PyGC_generation0: replaced with _PyRuntime.gc.generation0 * Python.h now automatically includes pycore_object.h
Copy link
Copy Markdown
Member
Author
|
PR #10507 has been merged: I rewrote and rebased this change on top of master. |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
|
I don't understand why compilation fails on AppVeyor: c:\projects\cpython\python\pytime.c(581): error C2037: left of 'tv_sec' specifies undefined struct/union 'timeval' [C:\projects\cpython\PCbuild\pythoncore.vcxproj] |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pycore_object.h
in _queuemodule.c. The file is compiled without Py_BUILD_CORE.
https://bugs.python.org/issue35081