gh-102192: Replace PyErr_Fetch/Restore etc by more efficient alternatives by iritkatriel · Pull Request #102769 · python/cpython · GitHub

Issue: Replace Fetch/Restore etc by the new exception APIs #102192

…ternatives

🤖 New build scheduled with the buildbot fleet by @iritkatriel for commit c5ff20d 🤖

If you want to schedule another build, you need to add the 🔨 test-with-refleak-buildbots label again.

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot s390x Fedora LTO 3.x has failed when building commit 1cb75a9.

What do you need to do:

Don't panic.
Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
Go to the page of the buildbot that failed (https://buildbot.python.org/all/#builders/55/builds/3136) and take a look at the build logs.
Check if the failure is related to this commit (1cb75a9) or if it is a false positive.
If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/all/#builders/55/builds/3136

Failed tests:

test_tools

Failed subtests:

test_all - test.test_eintr.EINTRTests.test_all
test_lockf - main.FNTLEINTRTest.test_lockf
test_freeze_simple_script - test.test_tools.test_freeze.TestFreeze.test_freeze_simple_script

Summary of the results of the build (if available):

== Tests result: FAILURE then FAILURE ==

414 tests OK.

10 slowest tests:

test_tools: 6 min 5 sec
test_compile: 2 min 54 sec
test_concurrent_futures: 2 min 13 sec
test_gdb: 2 min 13 sec
test_multiprocessing_spawn: 1 min 37 sec
test_signal: 1 min 12 sec
test_multiprocessing_fork: 1 min 12 sec
test_asyncio: 1 min 12 sec
test_multiprocessing_forkserver: 1 min 11 sec
test_socket: 49.3 sec

1 test failed:
test_tools

18 tests skipped:
test_devpoll test_ioctl test_kqueue test_launcher test_msilib
test_nis test_peg_generator test_perf_profiler test_readline
test_startfile test_tix test_tkinter test_ttk test_winconsoleio
test_winreg test_winsound test_wmi test_zipfile64

2 re-run tests:
test_eintr test_tools

Total duration: 13 min 26 sec

Click to see traceback logs

Traceback (most recent call last):
  File "/home/dje/cpython-buildarea/3.x.edelsohn-fedora-z.lto/build/Lib/test/test_eintr.py", line 16, in test_all
    script_helper.run_test_script(script)
  File "/home/dje/cpython-buildarea/3.x.edelsohn-fedora-z.lto/build/Lib/test/support/script_helper.py", line 300, in run_test_script
    raise AssertionError(f"{name} failed")
AssertionError: script _test_eintr.py failed


Traceback (most recent call last):
  File "<string>", line 1, in <module>
  File "/tmp/test_python_9_i9_axi/tmpn12971yj/cpython/Lib/sysconfig.py", line 740, in get_config_var
    return get_config_vars().get(name)
           ^^^^^^^^^^^^^^^^^
  File "/tmp/test_python_9_i9_axi/tmpn12971yj/cpython/Lib/sysconfig.py", line 723, in get_config_vars
    _init_config_vars()
  File "/tmp/test_python_9_i9_axi/tmpn12971yj/cpython/Lib/sysconfig.py", line 670, in _init_config_vars
    _init_posix(_CONFIG_VARS)
  File "/tmp/test_python_9_i9_axi/tmpn12971yj/cpython/Lib/sysconfig.py", line 536, in _init_posix
    _temp = __import__(name, globals(), locals(), ['build_time_vars'], 0)
            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
ModuleNotFoundError: No module named '_sysconfigdata__linux_s390x-linux-gnu'


Traceback (most recent call last):
  File "<string>", line 1, in <module>
  File "/tmp/tmp62q69ehf/cpython/Lib/sysconfig.py", line 740, in get_config_var
    return get_config_vars().get(name)
           ^^^^^^^^^^^^^^^^^
  File "/tmp/tmp62q69ehf/cpython/Lib/sysconfig.py", line 723, in get_config_vars
    _init_config_vars()
  File "/tmp/tmp62q69ehf/cpython/Lib/sysconfig.py", line 670, in _init_config_vars
    _init_posix(_CONFIG_VARS)
  File "/tmp/tmp62q69ehf/cpython/Lib/sysconfig.py", line 536, in _init_posix
    _temp = __import__(name, globals(), locals(), ['build_time_vars'], 0)
            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
ModuleNotFoundError: No module named '_sysconfigdata__linux_s390x-linux-gnu'


Traceback (most recent call last):
  File "/home/dje/cpython-buildarea/3.x.edelsohn-fedora-z.lto/build/Lib/test/test_tools/test_freeze.py", line 27, in test_freeze_simple_script
    outdir, scriptfile, python = helper.prepare(script, outdir)
                                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/dje/cpython-buildarea/3.x.edelsohn-fedora-z.lto/build/Tools/freeze/test/freeze.py", line 184, in prepare
    _run_quiet([MAKE, '-C', builddir, 'install'])
  File "/home/dje/cpython-buildarea/3.x.edelsohn-fedora-z.lto/build/Tools/freeze/test/freeze.py", line 25, in _run_quiet
    return subprocess.run(
           ^^^^^^^^^^^^^^^
  File "/home/dje/cpython-buildarea/3.x.edelsohn-fedora-z.lto/build/Lib/subprocess.py", line 571, in run
    raise CalledProcessError(retcode, process.args,
subprocess.CalledProcessError: Command '['/usr/bin/make', '-C', '/tmp/test_python_9_i9_axi/tmpn12971yj/python-build', 'install']' returned non-zero exit status 2.


Traceback (most recent call last):
  File "/home/dje/cpython-buildarea/3.x.edelsohn-fedora-z.lto/build/Lib/test/test_tools/test_freeze.py", line 27, in test_freeze_simple_script
    outdir, scriptfile, python = helper.prepare(script, outdir)
                                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/dje/cpython-buildarea/3.x.edelsohn-fedora-z.lto/build/Tools/freeze/test/freeze.py", line 184, in prepare
    _run_quiet([MAKE, '-C', builddir, 'install'])
  File "/home/dje/cpython-buildarea/3.x.edelsohn-fedora-z.lto/build/Tools/freeze/test/freeze.py", line 25, in _run_quiet
    return subprocess.run(
           ^^^^^^^^^^^^^^^
  File "/home/dje/cpython-buildarea/3.x.edelsohn-fedora-z.lto/build/Lib/subprocess.py", line 571, in run
    raise CalledProcessError(retcode, process.args,
subprocess.CalledProcessError: Command '['/usr/bin/make', '-C', '/tmp/tmp62q69ehf/python-build', 'install']' returned non-zero exit status 2.


Traceback (most recent call last):
  File "/home/dje/cpython-buildarea/3.x.edelsohn-fedora-z.lto/build/Lib/test/_test_eintr.py", line 523, in test_lockf
    self._lock(fcntl.lockf, "lockf")
  File "/home/dje/cpython-buildarea/3.x.edelsohn-fedora-z.lto/build/Lib/test/_test_eintr.py", line 515, in _lock
    self.assertGreaterEqual(dt, self.sleep_time)
AssertionError: 0.1989035690203309 not greater than or equal to 0.2

…ternatives (python#102769)

pythongh-102192 : Replace PyErr_Fetch/Restore etc by more efficient al…

c5ff20d

…ternatives

iritkatriel added skip news interpreter-core (Objects, Python, Grammar, and Parser dirs) labels Mar 17, 2023

bedevere-bot mentioned this pull request Mar 17, 2023

Replace Fetch/Restore etc by the new exception APIs #102192

Closed

bedevere-bot added the awaiting core review label Mar 17, 2023

iritkatriel added 🔨 test-with-refleak-buildbots Test PR w/ refleak buildbots; report in status section and removed awaiting core review labels Mar 17, 2023

bedevere-bot removed the 🔨 test-with-refleak-buildbots Test PR w/ refleak buildbots; report in status section label Mar 17, 2023

iritkatriel requested a review from kumaraditya303 March 17, 2023 22:42

kumaraditya303 approved these changes Mar 18, 2023

View reviewed changes

bedevere-bot added the awaiting merge label Mar 18, 2023

iritkatriel merged commit 1cb75a9 into python:main Mar 18, 2023

bedevere-bot removed the awaiting merge label Mar 18, 2023

Fidget-Spinner pushed a commit to Fidget-Spinner/cpython that referenced this pull request Mar 27, 2023

pythongh-102192 : Replace PyErr_Fetch/Restore etc by more efficient al…

863f705

…ternatives (python#102769)

iritkatriel deleted the fetch-errors branch April 3, 2023 17:42

warsaw pushed a commit to warsaw/cpython that referenced this pull request Apr 11, 2023

pythongh-102192 : Replace PyErr_Fetch/Restore etc by more efficient al…

e8188bd

…ternatives (python#102769)

gh-102192: Replace PyErr_Fetch/Restore etc by more efficient alternatives by iritkatriel · Pull Request #102769 · python/cpython · GitHub

Repository navigation

gh-102192: Replace PyErr_Fetch/Restore etc by more efficient alternatives - #102769

gh-102192: Replace PyErr_Fetch/Restore etc by more efficient alternatives#102769
iritkatriel merged 1 commit into
python:mainfrom
iritkatriel:fetch-errors

iritkatriel commented Mar 17, 2023 •
edited by bedevere-bot
Loading

Uh oh!

Uh oh!

bedevere-bot commented Mar 17, 2023

Uh oh!

bedevere-bot commented Mar 18, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

gh-102192: Replace PyErr_Fetch/Restore etc by more efficient alternatives by iritkatriel · Pull Request #102769 · python/cpython · GitHub

Repository navigation

gh-102192: Replace PyErr_Fetch/Restore etc by more efficient alternatives - #102769

gh-102192: Replace PyErr_Fetch/Restore etc by more efficient alternatives#102769iritkatriel merged 1 commit intopython:mainpython/cpython:mainfrom iritkatriel:fetch-errorsiritkatriel/cpython:fetch-errorsCopy head branch name to clipboard

Conversation

iritkatriel commented Mar 17, 2023 • edited by bedevere-bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

bedevere-bot commented Mar 17, 2023

Uh oh!

bedevere-bot commented Mar 18, 2023

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

gh-102192: Replace PyErr_Fetch/Restore etc by more efficient alternatives#102769
iritkatriel merged 1 commit into
python:mainfrom
iritkatriel:fetch-errors

iritkatriel commented Mar 17, 2023 •
edited by bedevere-bot
Loading