FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-101975: Fixed a potential SegFault on garbage collection by gaogaotiantian · Pull Request #102803 · python/cpython · GitHub

/ cpython Public

gh-101975: Fixed a potential SegFault on garbage collection - #102803

Merged
markshannon merged 2 commits into
python:mainfrom
gaogaotiantian:fix-issue-101975
Mar 18, 2023
ConversationCommits (2)ChecksFiles changed
Merged

gh-101975: Fixed a potential SegFault on garbage collection#102803
markshannon merged 2 commits into
python:mainfrom
gaogaotiantian:fix-issue-101975

Conversation

gaogaotiantian commented Mar 18, 2023 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Member

frame->stacktop = 1 is missing on trace entry which could cause the gc on another thread to access freed memory.

bedevere-bot mentioned this pull request Mar 18, 2023
Closed
markshannon self-requested a review March 18, 2023 10:55
markshannon approved these changes Mar 18, 2023
View reviewed changes

markshannon left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Looks good.

I quickly checked the other uses of _PyFrame_GetStackPointer(frame) and this is the odd one out.

markshannon added the needs backport to 3.11 only security fixes label Mar 18, 2023
markshannon merged commit 039714d into python:main Mar 18, 2023

miss-islington commented Mar 18, 2023

Copy link
Copy Markdown
Contributor

Thanks @gaogaotiantian for the PR, and @markshannon for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖

miss-islington commented Mar 18, 2023

Copy link
Copy Markdown
Contributor

Sorry, @gaogaotiantian and @markshannon, I could not cleanly backport this to 3.11 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 039714d00f147be4d018fa6aeaf174aad7e8fa32 3.11

markshannon pushed a commit to faster-cpython/cpython that referenced this pull request Mar 18, 2023
pythongh-101975: Fixed a potential SegFault on garbage collection (py…
1313007 
…thonGH-102803)
markshannon mentioned this pull request Mar 18, 2023
Merged

bedevere-bot commented Mar 18, 2023

Copy link
Copy Markdown

GH-102807 is a backport of this pull request to the 3.11 branch.

bedevere-bot removed the needs backport to 3.11 only security fixes label Mar 18, 2023
gaogaotiantian deleted the fix-issue-101975 branch March 18, 2023 14:41
markshannon added a commit that referenced this pull request Mar 20, 2023
[3.11] gh-101975: Fixed a potential SegFault on garbage collection (G…
d149f15 
…H-102803) (GH-102807)

Authored-by: gaogaotiantian <gaogaotiantian@hotmail.com>
Fidget-Spinner pushed a commit to Fidget-Spinner/cpython that referenced this pull request Mar 27, 2023
pythongh-101975: Fixed a potential SegFault on garbage collection (py…
b019008 
…thonGH-102803)
warsaw pushed a commit to warsaw/cpython that referenced this pull request Apr 11, 2023
pythongh-101975: Fixed a potential SegFault on garbage collection (py…
1087432 
…thonGH-102803)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

markshannon markshannon approved these changes

Assignees

markshannon

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

Back | FazBrowse Home | New Git URL