FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-102840: Fix confused traceback when `floordiv` or `mod` operations happens between `Fraction` and `complex` objects by Eclips4 · Pull Request #102842 · python/cpython · GitHub

  1. python
  2. cpython

Repository navigation

gh-102840: Fix confused traceback when floordiv or mod operations happens between Fraction and complex objects - #102842

Merged
serhiy-storchaka merged 10 commits into
python:mainfrom
Eclips4:issue-102840
Feb 10, 2024
ConversationCommits (10)ChecksFiles changed
Merged

gh-102840: Fix confused traceback when floordiv or mod operations happens between Fraction and complex objects#102842
serhiy-storchaka merged 10 commits into
python:mainfrom
Eclips4:issue-102840

Conversation

Eclips4 commented Mar 20, 2023 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Member

bedevere-bot mentioned this pull request Mar 20, 2023
Closed

Eclips4 commented Mar 20, 2023

Copy link
Copy Markdown
Member Author

cc @skirpichev

skirpichev requested changes Mar 20, 2023
View reviewed changes
Comment thread Lib/fractions.py Outdated
Comment thread Lib/fractions.py Outdated
Eclips4 requested a review from skirpichev March 20, 2023 12:36
skirpichev requested changes Mar 20, 2023
View reviewed changes
Comment thread Lib/test/test_fractions.py Outdated
Add sugestion from skirpichev
b03522e 
Co-authored-by: Sergey B Kirpichev <skirpichev@gmail.com>

Eclips4 commented Mar 20, 2023

Copy link
Copy Markdown
Member Author

Also, I think there no need in NEWS entry. But if someone want it - I'll add it.

skirpichev approved these changes Mar 20, 2023
View reviewed changes

skirpichev left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM

arhadthedev added the stdlib Standard Library Python modules in the Lib/ directory label Mar 22, 2023

arhadthedev commented Mar 22, 2023

Copy link
Copy Markdown
Member

@mdickinson (as a fraction expert)

Eclips4 commented Jan 1, 2024
View reviewed changes
Comment thread Lib/test/test_fractions.py Outdated
serhiy-storchaka reviewed Feb 2, 2024
View reviewed changes

serhiy-storchaka left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I do not think that silencing TypeError for any operation is right. It can silence some unexpected errors, it is also not very efficient. It would be better to just not try to perform unsupported operation. I suggest to add an optional parameter in _operator_fallbacks() to specify whether try to handle complex numbers or not. We know which operations are not supported by complex.

Comment thread Lib/test/test_fractions.py Outdated
Comment thread Lib/test/test_fractions.py Outdated

mdickinson commented Feb 10, 2024

Copy link
Copy Markdown
Member

I suggest to add an optional parameter in _operator_fallbacks() to specify whether try to handle complex numbers or not.

+1. This sounds like the right approach to me.

Eclips4 commented Feb 10, 2024

Copy link
Copy Markdown
Member Author

Do we need NEWS entry here? It's improves the user experience, so in my opinion - yes.

serhiy-storchaka reviewed Feb 10, 2024
View reviewed changes

serhiy-storchaka left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

This is a user visible change, so a NEWS entry will not make bad.

It will help if users wonder about confusing error messages in older Python.

Comment thread Lib/fractions.py Outdated
Comment thread Lib/test/test_fractions.py Outdated
skirpichev approved these changes Feb 10, 2024
View reviewed changes

skirpichev left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM, modulo minor nitpick about default value.

Comment thread Lib/fractions.py Outdated
Update Misc/NEWS.d/next/Library/2024-02-10-15-24-20.gh-issue-102840.4…
489b95d 
…mnDq1.rst

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
serhiy-storchaka merged commit 5319c66 into python:main Feb 10, 2024
fsc-eriker pushed a commit to fsc-eriker/cpython that referenced this pull request Feb 14, 2024
pythongh-102840: Fix confused traceback when floordiv or mod operatio…
bec39e4 
…ns happens between Fraction and complex objects (pythonGH-102842)
scoder added a commit to scoder/quicktions that referenced this pull request Nov 28, 2024
Prevent 'complex' handling in division methods.
302375b 
See python/cpython#102842
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

skirpichev skirpichev approved these changes
serhiy-storchaka serhiy-storchaka approved these changes

Assignees

No one assigned

Labels

stdlib Standard Library Python modules in the Lib/ directory

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

Back | FazBrowse Home | New Git URL