FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-102936: typing: document performance pitfalls of protocols decorated with `@runtime_checkable` by AlexWaygood · Pull Request #102937 · python/cpython · GitHub

/ cpython Public

gh-102936: typing: document performance pitfalls of protocols decorated with @runtime_checkable - #102937

Merged
AlexWaygood merged 2 commits into
python:mainfrom
AlexWaygood:document-runtime_checkable-quite-bad
Mar 23, 2023
ConversationCommits (2)ChecksFiles changed
Merged

gh-102936: typing: document performance pitfalls of protocols decorated with @runtime_checkable#102937
AlexWaygood merged 2 commits into
python:mainfrom
AlexWaygood:document-runtime_checkable-quite-bad

Conversation

AlexWaygood commented Mar 22, 2023 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Member

bedevere-bot added docs Documentation in the Doc dir skip news labels Mar 22, 2023
bedevere-bot mentioned this pull request Mar 22, 2023
Closed
gvanrossum approved these changes Mar 22, 2023
View reviewed changes

gvanrossum left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Makes sense.

hauntsaninja reviewed Mar 23, 2023
View reviewed changes

hauntsaninja left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Thanks for doing this! Had one suggestion for a different example of attribute

Comment thread Doc/library/typing.rst

assert isinstance(open('/some/file'), Closable)

@runtime_checkable

hauntsaninja Mar 23, 2023

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I think many users aren't too familiar with OSError's constructor / we can't use kwargs and it's unclear what the second argument is. Maybe we could use int and HasNumerator instead?

(I know it's not writeable, but OSError's errno also is maybe not writeable? Writing to errno doesn't affect repr)

AlexWaygood Mar 23, 2023

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Yeah, I was really struggling to think of a good example for this! I'll ponder some more and see if I can come up with something better...

hauntsaninja Mar 23, 2023

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Perhaps unsurprisingly, not too many good cases of writeable attributes in stdlib. Maybe Thread.name? It's explicitly documented as something you can write to.

AlexWaygood Mar 23, 2023

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

That works! I'll make the change tomorrow (it's late here)

Comment thread Doc/library/typing.rst
AlexWaygood merged commit 58d2b30 into python:main Mar 23, 2023

miss-islington commented Mar 23, 2023

Copy link
Copy Markdown
Contributor

Thanks @AlexWaygood for the PR 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.11.
🐍🍒⛏🤖

AlexWaygood deleted the document-runtime_checkable-quite-bad branch March 23, 2023 18:18
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Mar 23, 2023
pythongh-102936: typing: document performance pitfalls of protocols d…
924e20e 
…ecorated with `@runtime_checkable` (pythonGH-102937)

(cherry picked from commit 58d2b30)

Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>

bedevere-bot commented Mar 23, 2023

Copy link
Copy Markdown

GH-102963 is a backport of this pull request to the 3.11 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Mar 23, 2023
pythongh-102936: typing: document performance pitfalls of protocols d…
8cd301d 
…ecorated with `@runtime_checkable` (pythonGH-102937)

(cherry picked from commit 58d2b30)

Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
bedevere-bot removed the needs backport to 3.11 only security fixes label Mar 23, 2023

bedevere-bot commented Mar 23, 2023

Copy link
Copy Markdown

GH-102964 is a backport of this pull request to the 3.10 branch.

bedevere-bot removed the needs backport to 3.10 only security fixes label Mar 23, 2023

AlexWaygood commented Mar 23, 2023

Copy link
Copy Markdown
Member Author

Thanks all for the reviews!

miss-islington added a commit that referenced this pull request Mar 23, 2023
gh-102936: typing: document performance pitfalls of protocols decorat…
e2924c0 
…ed with `@runtime_checkable` (GH-102937)

(cherry picked from commit 58d2b30)

Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
miss-islington added a commit that referenced this pull request Mar 23, 2023
gh-102936: typing: document performance pitfalls of protocols decorat…
6c667d0 
…ed with `@runtime_checkable` (GH-102937)

(cherry picked from commit 58d2b30)

Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
Fidget-Spinner pushed a commit to Fidget-Spinner/cpython that referenced this pull request Mar 27, 2023
pythongh-102936: typing: document performance pitfalls of protocols d…
10b47a8 
…ecorated with `@runtime_checkable` (python#102937)
AlexWaygood mentioned this pull request Apr 5, 2023
Closed
warsaw pushed a commit to warsaw/cpython that referenced this pull request Apr 11, 2023
pythongh-102936: typing: document performance pitfalls of protocols d…
0933b35 
…ecorated with `@runtime_checkable` (python#102937)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

gvanrossum gvanrossum approved these changes
hauntsaninja hauntsaninja approved these changes
furkanonder furkanonder approved these changes
Fidget-Spinner Awaiting requested review from Fidget-Spinner
JelleZijlstra Awaiting requested review from JelleZijlstra JelleZijlstra is a code owner

Assignees

No one assigned

Labels

docs Documentation in the Doc dir skip news topic-typing

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

Back | FazBrowse Home | New Git URL