gh-102939: Fix "conversion from Py_ssize_t to long" warning in builtins - #102940
Merged
markshannon merged 1 commit intoMar 23, 2023
Merged
gh-102939: Fix "conversion from Py_ssize_t to long" warning in builtins#102940markshannon merged 1 commit into
markshannon merged 1 commit into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
|
Looks like the warning is gone! 🎉 I've opened a new issue about ‘subobj’ may be used uninitialized in this function [-Wmaybe-uninitialized]: #102941 |
Sorry, something went wrong.
markshannon
approved these changes
Mar 23, 2023
markshannon
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Thanks for fixing this
Sorry, something went wrong.
Fidget-Spinner
pushed a commit
to Fidget-Spinner/cpython
that referenced
this pull request
Mar 27, 2023
warsaw
pushed a commit
to warsaw/cpython
that referenced
this pull request
Apr 11, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since we now work with Py_size_t instead of long (see 7559f5f#diff-e4fd8b8ee6a147f86c0719ff122aca6dfca36edbd4812c87892698b3b72e40a1) I've change the PyLong_ constructor.