gh-87092: move CFG related code from compile.c to flowgraph.c by iritkatriel · Pull Request #103021 · python/cpython · GitHub

Issue: Split compiler into code-gen, optimizer and assembler. #87092

…ompile.c there, so they can be shared

🤖 New build scheduled with the buildbot fleet by @iritkatriel for commit abaeeac 🤖

If you want to schedule another build, you need to add the 🔨 test-with-buildbots label again.

A bit of duplicated code, otherwise looks fine.

I don't think _PyOpcode_RelativeJump is needed any more, as all jumps are relative.

When you're done making the requested changes, leave the comment: I have made the requested changes; please review again.

And if you don't make the requested changes, you will be put in the comfy chair!

I don't think _PyOpcode_RelativeJump is needed any more, as all jumps are relative.

I agree, but I'd like to do it in a separate PR because I would need to remove usages and the diff here is large enough.

I have made the requested changes; please review again.

Thanks for making the requested changes!

@markshannon: please review the changes made to this pull request.

…ython#103021)

iritkatriel added 2 commits March 24, 2023 19:52

pythongh-87092 : create new opcode_utils.h file and move macros from c…

5eea154

…ompile.c there, so they can be shared

pythongh-87092 : move CFG related code from compile.c to cfg.c

b5244da

iritkatriel requested a review from markshannon as a code owner March 24, 2023 23:17

bedevere-bot mentioned this pull request Mar 24, 2023

Split compiler into code-gen, optimizer and assembler. #87092

Closed

bedevere-bot added the awaiting core review label Mar 24, 2023

iritkatriel added skip news interpreter-core (Objects, Python, Grammar, and Parser dirs) labels Mar 24, 2023

iritkatriel added 3 commits March 24, 2023 23:40

remove include

abb6f26

make globals const

91a8743

update pcbuild

abaeeac

iritkatriel requested a review from a team as a code owner March 25, 2023 18:48

iritkatriel added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Mar 25, 2023

bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Mar 25, 2023

iritkatriel and others added 3 commits March 25, 2023 23:46

Merge branch 'main' into cfg.c

fb15754

move a few more functions from compile.c to cfg.c

8f21775

cfg.c --> cfg_opt.c

a38cbcd

iritkatriel changed the title gh-87092: move CFG related code from compile.c to cfg.c gh-87092: move CFG related code from compile.c to cfg_opt.c Mar 27, 2023

iritkatriel added 4 commits March 27, 2023 18:33

update pcbuild files

0f78101

and makefile

b273dd0

fix include

5909b64

cfg_opt --> flowgraph

6f52884

iritkatriel changed the title gh-87092: move CFG related code from compile.c to cfg_opt.c gh-87092: move CFG related code from compile.c to flowgraph.c Mar 29, 2023

iritkatriel and others added 2 commits March 30, 2023 11:37

Merge remote-tracking branch 'upstream/main' into cfg.c

beb28f6

Merge branch 'main' into cfg.c

b6baa7b

markshannon requested changes Mar 31, 2023

View reviewed changes

Comment thread Include/internal/pycore_compile.h Outdated

Comment thread Include/internal/pycore_opcode_utils.h

Comment thread Include/internal/pycore_opcode_utils.h Outdated

bedevere-bot added awaiting changes and removed awaiting core review labels Mar 31, 2023

remove duplicated macros. rename arr_ --> array

d1f0c66

bedevere-bot added awaiting change review and removed awaiting changes labels Mar 31, 2023

bedevere-bot requested a review from markshannon March 31, 2023 16:47

markshannon approved these changes Mar 31, 2023

View reviewed changes

bedevere-bot added awaiting merge and removed awaiting change review labels Mar 31, 2023

iritkatriel merged commit 80163e1 into python:main Mar 31, 2023

bedevere-bot removed the awaiting merge label Mar 31, 2023

iritkatriel deleted the cfg.c branch April 3, 2023 17:41

warsaw pushed a commit to warsaw/cpython that referenced this pull request Apr 11, 2023

pythongh-87092 : move CFG related code from compile.c to flowgraph.c (p…

68bbf79

…ython#103021)

gh-87092: move CFG related code from compile.c to flowgraph.c by iritkatriel · Pull Request #103021 · python/cpython · GitHub

Uh oh!

Uh oh!

gh-87092: move CFG related code from compile.c to flowgraph.c - #103021

gh-87092: move CFG related code from compile.c to flowgraph.c#103021
iritkatriel merged 15 commits into
python:mainfrom
iritkatriel:cfg.c

iritkatriel commented Mar 24, 2023 •
edited by bedevere-bot
Loading

Uh oh!

Uh oh!

bedevere-bot commented Mar 25, 2023

Uh oh!

markshannon left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

bedevere-bot commented Mar 31, 2023

Uh oh!

iritkatriel commented Mar 31, 2023

Uh oh!

iritkatriel commented Mar 31, 2023

Uh oh!

bedevere-bot commented Mar 31, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

gh-87092: move CFG related code from compile.c to flowgraph.c by iritkatriel · Pull Request #103021 · python/cpython · GitHub

Uh oh!

Uh oh!

gh-87092: move CFG related code from compile.c to flowgraph.c - #103021

gh-87092: move CFG related code from compile.c to flowgraph.c#103021iritkatriel merged 15 commits intopython:mainpython/cpython:mainfrom iritkatriel:cfg.ciritkatriel/cpython:cfg.cCopy head branch name to clipboard

Conversation

iritkatriel commented Mar 24, 2023 • edited by bedevere-bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

bedevere-bot commented Mar 25, 2023

Uh oh!

markshannon left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

bedevere-bot commented Mar 31, 2023

Uh oh!

iritkatriel commented Mar 31, 2023

Uh oh!

iritkatriel commented Mar 31, 2023

Uh oh!

bedevere-bot commented Mar 31, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

gh-87092: move CFG related code from compile.c to flowgraph.c#103021
iritkatriel merged 15 commits into
python:mainfrom
iritkatriel:cfg.c

iritkatriel commented Mar 24, 2023 •
edited by bedevere-bot
Loading