| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
There was a problem hiding this comment.
LGTM, I finished the remaining bits.
Sorry, something went wrong.
|
Now it crashes in the dict watcher deallocation, cc @carljm |
Sorry, something went wrong.
See 45a26f3, which I believe is the correct prescription. Notice that PyDict_Type.tp_init is called explicitly from defdict_init. IIRC, that is not needed, but I may be wrong (I'm unable to check that right now). |
Sorry, something went wrong.
|
BTW, there are ref. leaks, so we need to hold off a little bit more. Try for example checking ref. leaks on test_defaultdict. |
Sorry, something went wrong.
|
🤖 New build scheduled with the buildbot fleet by @erlend-aasland for commit 0dcfcef 🤖 If you want to schedule another build, you need to add the 🔨 test-with-refleak-buildbots label again. |
Sorry, something went wrong.
|
🤖 New build scheduled with the buildbot fleet by @kumaraditya303 for commit 0381b45 🤖 If you want to schedule another build, you need to add the 🔨 test-with-buildbots label again. |
Sorry, something went wrong.
|
Good find! No ref.leaks locally over here. |
Sorry, something went wrong.
There was a problem hiding this comment.
Final approval!
Sorry, something went wrong.
|
Good job! |
Sorry, something went wrong.
Co-authored-by: Kumar Aditya <59607654+kumaraditya303@users.noreply.github.com>
| Back | FazBrowse Home | New Git URL |
Uh oh!
There was an error while loading. Please reload this page.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.