gh-103112: Add http.client.HTTPResponse.read docstring and fix pydoc output - #103113
Merged
terryjreedy merged 8 commits intoMar 29, 2023
Merged
gh-103112: Add http.client.HTTPResponse.read docstring and fix pydoc output#103113terryjreedy merged 8 commits into
terryjreedy merged 8 commits into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Copy link
Copy Markdown
|
Most changes to Python require a NEWS entry. Please add it using the blurb_it web app or the blurb command-line tool. |
Sorry, something went wrong.
Copy link
Copy Markdown
|
All commit authors signed the Contributor License Agreement. |
Sorry, something went wrong.
terryjreedy
reviewed
Mar 29, 2023
Comment thread
Lib/http/client.py
Outdated
terryjreedy
reviewed
Mar 29, 2023
Comment thread
Misc/NEWS.d/next/Documentation/2023-03-29-14-51-39.gh-issue-103112.XgGSEO.rst
Outdated
terryjreedy
reviewed
Mar 29, 2023
Comment thread
Misc/NEWS.d/next/Documentation/2023-03-29-14-51-39.gh-issue-103112.XgGSEO.rst
Outdated
merwok
reviewed
Mar 29, 2023
Comment thread
Lib/http/client.py
Outdated
merwok
reviewed
Mar 29, 2023
Comment thread
Misc/NEWS.d/next/Documentation/2023-03-29-14-51-39.gh-issue-103112.XgGSEO.rst
Outdated
Co-authored-by: Éric <merwok@netwok.org>
…3112.XgGSEO.rst Co-authored-by: Éric <merwok@netwok.org>
Copy link
Copy Markdown
Member
|
I visually verified both the issue and the fix. |
Sorry, something went wrong.
terryjreedy
reviewed
Mar 29, 2023
Comment thread
Misc/NEWS.d/next/Documentation/2023-03-29-14-51-39.gh-issue-103112.XgGSEO.rst
Outdated
Copy link
Copy Markdown
Member
|
@merwok Failures because 'cmd' is not a known role. I removed it. |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
Ah it’s program not cmd! |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
Thanks @bwagner for the PR, and @terryjreedy for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.11. |
Sorry, something went wrong.
Copy link
Copy Markdown
|
GH-103119 is a backport of this pull request to the 3.11 branch. |
Sorry, something went wrong.
Copy link
Copy Markdown
|
GH-103120 is a backport of this pull request to the 3.10 branch. |
Sorry, something went wrong.
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Mar 29, 2023
…pydoc output (pythonGH-103113) (cherry picked from commit d052a38) Co-authored-by: Bernhard Wagner <github.comNotification20120125@xmlizer.net> Co-authored-by: blurb-it[bot] <43283697+blurb-it[bot]@users.noreply.github.com> Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu> Co-authored-by: Éric <merwok@netwok.org>
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Mar 29, 2023
…pydoc output (pythonGH-103113) (cherry picked from commit d052a38) Co-authored-by: Bernhard Wagner <github.comNotification20120125@xmlizer.net> Co-authored-by: blurb-it[bot] <43283697+blurb-it[bot]@users.noreply.github.com> Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu> Co-authored-by: Éric <merwok@netwok.org>
terryjreedy
added a commit
that referenced
this pull request
Mar 29, 2023
… pydoc output (GH-103113) (#103119) (cherry picked from commit d052a38) Co-authored-by: Bernhard Wagner <github.comNotification20120125@xmlizer.net> Co-authored-by: blurb-it[bot] <43283697+blurb-it[bot]@users.noreply.github.com> Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu> Co-authored-by: Éric <merwok@netwok.org>
terryjreedy
added a commit
that referenced
this pull request
Mar 29, 2023
… pydoc output (GH-103113) (#103120) (cherry picked from commit d052a38) Co-authored-by: Bernhard Wagner <github.comNotification20120125@xmlizer.net> Co-authored-by: blurb-it[bot] <43283697+blurb-it[bot]@users.noreply.github.com> Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu> Co-authored-by: Éric <merwok@netwok.org>
warsaw
pushed a commit
to warsaw/cpython
that referenced
this pull request
Apr 11, 2023
…pydoc output (python#103113) Co-authored-by: blurb-it[bot] <43283697+blurb-it[bot]@users.noreply.github.com> Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu> Co-authored-by: Éric <merwok@netwok.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pydoc http.client.HTTPResponse.read
results in help text:
http.client.HTTPResponse.read = read(self, amt=None) Read and return up to n bytes.The parameter is called “amt” but the help text refers to “n”.
Issue 103112
Discussion