FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-103193: Micro-optimise helper functions for `inspect.getattr_static` by AlexWaygood · Pull Request #103195 · python/cpython · GitHub

/ cpython Public

gh-103193: Micro-optimise helper functions for inspect.getattr_static #103195

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AlexWaygood merged 2 commits into from
Apr 5, 2023
+5 −4
Conversation 14 Commits 2 Checks 0 Files changed 2
Merged

gh-103193: Micro-optimise helper functions for inspect.getattr_static #103195

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
469e165
gh-103193: Micro-optimise helper functions for `inspect.getattr_static`
AlexWaygood Apr 2, 2023
49c0352
Address review
AlexWaygood Apr 3, 2023
File filter

Filter by extension

Filter by extension .py  (1) .rst  (1) All 2 file types selected
Viewed files
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Unified
Split
Hide whitespace
Diff view
Unified
Split
Hide whitespace
7 changes: 3 additions & 4 deletions Lib/inspect.py
Show comments
View file
Open in desktop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Original file line number Diff line number Diff line change
Expand Up @@ -1772,9 +1772,9 @@ def trace(context=1):
# ------------------------------------------------ static version of getattr

_sentinel = object()
_static_getmro = type.__dict__['__mro__'].__get__
_get_dunder_dict_of_class = type.__dict__["__dict__"].__get__

def _static_getmro(klass):
return type.__dict__['__mro__'].__get__(klass)

def _check_instance(obj, attr):
instance_dict = {}
Expand Down Expand Up @@ -1802,10 +1802,9 @@ def _is_type(obj):
return True

def _shadowed_dict(klass):
dict_attr = type.__dict__["__dict__"]
for entry in _static_getmro(klass):
try:
class_dict = dict_attr.__get__(entry)["__dict__"]
class_dict = _get_dunder_dict_of_class(entry)["__dict__"]
except KeyError:
pass
else:
Expand Down
2 changes: 2 additions & 0 deletions Misc/NEWS.d/next/Library/2023-04-02-17-51-08.gh-issue-103193.xrZbM1.rst
Show comments
View file
Open in desktop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
Improve performance of :func:`inspect.getattr_static`. Patch by Alex
Waygood.
Back | FazBrowse Home | New Git URL