gh-103092: Isolate winreg - #103250
Merged
erlend-aasland merged 34 commits intoApr 17, 2023
Merged
Conversation
arhadthedev
reviewed
Apr 5, 2023
Comment thread
PC/winreg.c
Outdated
Co-authored-by: Oleg Iarygin <dralife@yandex.ru>
aisk
marked this pull request as ready for review
April 7, 2023 16:50
Copy link
Copy Markdown
Member
|
Hm.. CI/CD says there is a certain amount of refleaks |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
|
Yes, working on it |
Sorry, something went wrong.
erlend-aasland
self-requested a review
April 8, 2023 19:48
Comment thread
Lib/test/test_winreg.py
Comment thread
Misc/NEWS.d/next/Library/2023-04-08-00-48-40.gh-issue-103092.5EFts0.rst
Outdated
Comment thread
PC/winreg.c
Outdated
Comment thread
PC/winreg.c
Outdated
Comment thread
PC/winreg.c
Outdated
Comment thread
PC/winreg.c
Outdated
Comment thread
PC/winreg.c
Outdated
Comment thread
PC/winreg.c
Outdated
Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com>
…EFts0.rst Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com>
Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com>
Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com>
Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com>
Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com>
Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com>
using PyModule_GetState instead of _PyModule_GetState
erlend-aasland
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Thanks, I think we're soon ready for landing (and of course a thumbs up from Steve or someone else from the Windows team).
I left some more nit picks :)
Sorry, something went wrong.
Comment thread
Lib/test/test_winreg.py
Outdated
Comment thread
PC/winreg.c
Outdated
Comment thread
PC/winreg.c
Outdated
Comment thread
PC/winreg.c
Outdated
Comment thread
PC/winreg.c
Outdated
Comment thread
PC/winreg.c
Outdated
Comment thread
PC/winreg.c
Outdated
Comment thread
PC/winreg.c
Outdated
Comment thread
PC/winreg.c
Outdated
Comment thread
PC/winreg.c
Outdated
Eclips4
reviewed
Apr 9, 2023
Comment thread
PC/winreg.c
Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com>
Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com>
Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com>
Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com>
Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com>
Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com>
Co-authored-by: Kirill <80244920+Eclips4@users.noreply.github.com>
arhadthedev
reviewed
Apr 10, 2023
Comment thread
PC/winreg.c
Outdated
Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com>
Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com>
erlend-aasland
approved these changes
Apr 13, 2023
Comment thread
PC/winreg.c
Outdated
Copy link
Copy Markdown
Contributor
|
Thanks, @aisk! Let's wait for Steve's thumbs up before we land this. |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
|
Great thanks for helping and review this! @erlend-aasland |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
Seems okay to me, though I'm not really up on these conversions. If all the tests (esp. refleak tests) are still passing, it's presumably fine. |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.