gh-103224: Resolve paths properly in test_sysconfig - #103292
Merged
serhiy-storchaka merged 2 commits intoFeb 6, 2024
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
To pass tests when executed through a Python symlink. Co-authored-by: Miro Hrončok <miro@hroncok.cz>
2 tasks
serhiy-storchaka
approved these changes
Feb 6, 2024
serhiy-storchaka
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
This change looks safe.
Sorry, something went wrong.
serhiy-storchaka
enabled auto-merge (squash)
February 6, 2024 17:25
Copy link
Copy Markdown
|
Thanks @artemmukhin for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12. |
Sorry, something went wrong.
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Feb 6, 2024
Copy link
Copy Markdown
|
GH-115100 is a backport of this pull request to the 3.12 branch. |
Sorry, something went wrong.
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Feb 6, 2024
Copy link
Copy Markdown
|
GH-115101 is a backport of this pull request to the 3.11 branch. |
Sorry, something went wrong.
serhiy-storchaka
pushed a commit
that referenced
this pull request
Feb 7, 2024
serhiy-storchaka
pushed a commit
that referenced
this pull request
Feb 7, 2024
fsc-eriker
pushed a commit
to fsc-eriker/cpython
that referenced
this pull request
Feb 14, 2024
…03292) To pass tests when executed through a Python symlink. Co-authored-by: Miro Hrončok <miro@hroncok.cz>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now running tests through a Python symlink no longer causes test_nt_venv_scheme and test_posix_venv_scheme to fail.
@hroncok Thank you for helping!