Revert "gh-102213: Optimize the performance of __getattr__ (GH-102248)" - #103332
Merged
Fidget-Spinner merged 1 commit intoApr 7, 2023
Merged
Revert "gh-102213: Optimize the performance of __getattr__ (GH-102248)"#103332Fidget-Spinner merged 1 commit into
Fidget-Spinner merged 1 commit into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
…ythonGH-102248)" This reverts commit aa0a73d.
Copy link
Copy Markdown
Member
|
Sure, but do you know which file should I add this to? |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
|
I think that this one is the best place: https://github.com/python/cpython/blob/main/Lib/test/test_descr.py |
Sorry, something went wrong.
Fidget-Spinner
approved these changes
Apr 7, 2023
This was referenced Apr 8, 2023
warsaw
pushed a commit
to warsaw/cpython
that referenced
this pull request
Apr 11, 2023
… `__getattr__` (pythonGH-102248)" (pythonGH-103332) This reverts commit aa0a73d.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit caused at least two regressions:
CC @wangxiang-hz @Fidget-Spinner @sunmy2019
@sunmy2019 can you please send your test case as the next PR?
I want to keep this one a pure revert, with no extra changes :)