FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-102832: IDLE - remove use of deprecated sys.last_xyzs for stackviewer by iritkatriel · Pull Request #103339 · python/cpython · GitHub

/ cpython Public

gh-102832: IDLE - remove use of deprecated sys.last_xyzs for stackviewer - #103339

Merged
iritkatriel merged 8 commits into
python:mainfrom
iritkatriel:stackbrowser
Jun 8, 2023
ConversationCommits (8)ChecksFiles changed
Merged

gh-102832: IDLE - remove use of deprecated sys.last_xyzs for stackviewer#103339
iritkatriel merged 8 commits into
python:mainfrom
iritkatriel:stackbrowser

Conversation

iritkatriel commented Apr 7, 2023 •
edited by terryjreedy
Loading

Copy link
Copy Markdown
Member

Pass the exception as an argument instead of as a sys attribute.

iritkatriel requested a review from terryjreedy as a code owner April 7, 2023 10:12
bedevere-bot mentioned this pull request Apr 7, 2023
Closed

iritkatriel commented Apr 7, 2023

Copy link
Copy Markdown
Member Author

I see - the tests are skipped on Mac so I didn’t see them fail. I’ll try later on windows and fix this.

iritkatriel added skip news stdlib Standard Library Python modules in the Lib/ directory labels Apr 7, 2023
terryjreedy requested changes Apr 7, 2023
View reviewed changes

terryjreedy left a comment •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Order of PRs: (edited)

  1. Set sys.last_exc in run print_exception. #103314 (Done)
  2. Patch pyshell open_stack_viewer (comment on StackBrowser/stackbrowser)
  3. Apply this with changes and additional changes to open_stack_viewer and run-stackviewer and maybe new unittests.

Now working on 2 and 3.

The comments make a bit more sense when read in order on the diff page.

Comment thread Lib/idlelib/stackviewer.py Outdated
Comment thread Lib/idlelib/stackviewer.py Outdated
Comment thread Lib/idlelib/stackviewer.py Outdated
Comment thread Lib/idlelib/stackviewer.py Outdated
Comment thread Lib/idlelib/stackviewer.py Outdated
Comment thread Lib/idlelib/stackviewer.py Outdated
Comment thread Lib/idlelib/idle_test/test_stackviewer.py

bedevere-bot commented Apr 7, 2023

Copy link
Copy Markdown

When you're done making the requested changes, leave the comment: I have made the requested changes; please review again.

terryjreedy changed the title gh-102832: [idle] reduce use of deprecated sys.last_xyzs gh-102832: IDLE - reduce use of deprecated sys.last_xyzs Apr 7, 2023
terryjreedy self-assigned this Apr 7, 2023
terryjreedy changed the title gh-102832: IDLE - reduce use of deprecated sys.last_xyzs gh-102832: IDLE - remove use of deprecated sys.last_xyzs for stackviewer Apr 19, 2023

terryjreedy commented Apr 21, 2023 •
edited
Loading

Copy link
Copy Markdown
Member

I am reversing 2. patch open_stack_viewer and 3. everything else by including changing open_stack_viewer to pass sys.last_value, which is valid in 3.11 and 3.12.

After merging this, I will patch main and 3.12 only to pass last_exc instead of last_value, thus removing, I believe, the last use of a deprecated value.

iritkatriel commented Jun 6, 2023

Copy link
Copy Markdown
Member Author

Sorry, this seems to have dropped off my radar somehow. I'll update it now.

iritkatriel commented Jun 6, 2023

Copy link
Copy Markdown
Member Author

Actually, are you working on this? (You seem to indicate so in #103339 (review)).

terryjreedy commented Jun 7, 2023

Copy link
Copy Markdown
Member

I have a partly done branch. Will make this a priority tomorrow.

terryjreedy marked this pull request as draft June 8, 2023 01:21
terryjreedy added needs backport to 3.11 only security fixes needs backport to 3.12 only security fixes labels Jun 8, 2023
terryjreedy marked this pull request as ready for review June 8, 2023 03:48

terryjreedy commented Jun 8, 2023

Copy link
Copy Markdown
Member

Assuming CI passes, I believe ready now. Will recheck tomorrow.

iritkatriel commented Jun 8, 2023
View reviewed changes
Comment thread Lib/idlelib/pyshell.py
iritkatriel merged commit 3ee921d into python:main Jun 8, 2023

miss-islington commented Jun 8, 2023

Copy link
Copy Markdown
Contributor

Thanks @iritkatriel for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 8, 2023
pythongh-102832: IDLE - remove use of deprecated sys.last_xyzs for st…
894fdf3 
…ackviewer (pythonGH-103339)

(cherry picked from commit 3ee921d)

Co-authored-by: Irit Katriel <1055913+iritkatriel@users.noreply.github.com>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 8, 2023
pythongh-102832: IDLE - remove use of deprecated sys.last_xyzs for st…
89d3962 
…ackviewer (pythonGH-103339)

(cherry picked from commit 3ee921d)

Co-authored-by: Irit Katriel <1055913+iritkatriel@users.noreply.github.com>

bedevere-bot commented Jun 8, 2023

Copy link
Copy Markdown

GH-105526 is a backport of this pull request to the 3.12 branch.

bedevere-bot removed the needs backport to 3.12 only security fixes label Jun 8, 2023

bedevere-bot commented Jun 8, 2023

Copy link
Copy Markdown

GH-105527 is a backport of this pull request to the 3.11 branch.

bedevere-bot removed the needs backport to 3.11 only security fixes label Jun 8, 2023
terryjreedy pushed a commit that referenced this pull request Jun 8, 2023
[3.11] gh-102832: IDLE - remove use of deprecated sys.last_xyzs for s…
c2df09f 
…tackviewer (GH-103339) (#105527)

gh-102832: IDLE - remove use of deprecated sys.last_xyzs for stackviewer (GH-103339)
(cherry picked from commit 3ee921d)

Co-authored-by: Irit Katriel <1055913+iritkatriel@users.noreply.github.com>
terryjreedy pushed a commit that referenced this pull request Jun 8, 2023
[3.12] gh-102832: IDLE - remove use of deprecated sys.last_xyzs for s…
f565fed 
…tackviewer (GH-103339) (#105526)

gh-102832: IDLE - remove use of deprecated sys.last_xyzs for stackviewer (GH-103339)
(cherry picked from commit 3ee921d)

Co-authored-by: Irit Katriel <1055913+iritkatriel@users.noreply.github.com>
iritkatriel deleted the stackbrowser branch July 25, 2023 18:02
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

terryjreedy terryjreedy approved these changes

Assignees

terryjreedy

Labels

skip news stdlib Standard Library Python modules in the Lib/ directory

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

Back | FazBrowse Home | New Git URL