Fix old behaviour in typing documentation - #103400
Merged
AlexWaygood merged 1 commit intoApr 9, 2023
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
>>> class Z(Generic[T, P]): ... ... >>> Z[int, [dict, float]] __main__.Z[int, [dict, float]]
Gobot1234
requested review from
AlexWaygood,
Fidget-Spinner,
JelleZijlstra and
gvanrossum
as code owners
April 9, 2023 20:14
Copy link
Copy Markdown
Contributor
Author
|
Should this be backported to 3.11? It doesn't look like the original fix was |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
Good point |
Sorry, something went wrong.
AlexWaygood
approved these changes
Apr 9, 2023
AlexWaygood
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
We should probably change it so that these REPL snippets are actually run as part of CPython's doctest suite. But that can wait.
Sorry, something went wrong.
warsaw
pushed a commit
to warsaw/cpython
that referenced
this pull request
Apr 11, 2023
aisk
pushed a commit
to aisk/cpython
that referenced
this pull request
Apr 18, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #102637