FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-103180: Add CI timeouts to all GitHub Actions jobs by sobolevn · Pull Request #103437 · python/cpython · GitHub

/ cpython Public

gh-103180: Add CI timeouts to all GitHub Actions jobs - #103437

Merged
hugovk merged 1 commit into
python:mainfrom
sobolevn:issue-103180
Apr 14, 2023
ConversationCommits (1)ChecksFiles changed
Merged

gh-103180: Add CI timeouts to all GitHub Actions jobs#103437
hugovk merged 1 commit into
python:mainfrom
sobolevn:issue-103180

Conversation

sobolevn commented Apr 11, 2023 •
edited
Loading

Copy link
Copy Markdown
Member

bedevere-bot mentioned this pull request Apr 11, 2023
Closed
sobolevn added skip news build The build process and cross-build labels Apr 11, 2023
sobolevn changed the title gh-103180: Add CI timeouts to all GtiHub Actions jobs gh-103180: Add CI timeouts to all GitHub Actions jobs Apr 11, 2023
hugovk approved these changes Apr 11, 2023
View reviewed changes

hugovk left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Thanks for the analysis at #103180 (comment).

We could probably skip timeouts for the short ones: timeouts tend to occur in the more complex and therefore slower ones, but I'm also fine adding them just in case.

This comment was marked as spam.

Sign in to view

sobolevn commented Apr 11, 2023

Copy link
Copy Markdown
Member Author

@Ismaelkadir sorry, I don't understand your message :(

This comment was marked as spam.

Sign in to view
hauntsaninja approved these changes Apr 14, 2023
View reviewed changes

hauntsaninja left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Thanks for doing this!

hugovk merged commit be8903e into python:main Apr 14, 2023
hugovk added the needs backport to 3.11 only security fixes label Apr 14, 2023

miss-islington commented Apr 14, 2023

Copy link
Copy Markdown
Contributor

Thanks @sobolevn for the PR, and @hugovk for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

miss-islington commented Apr 14, 2023

Copy link
Copy Markdown
Contributor

Sorry, @sobolevn and @hugovk, I could not cleanly backport this to 3.11 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker be8903eb9d66ef1229f93a3a6036aeafc3bb0bda 3.11

sobolevn commented Apr 14, 2023

Copy link
Copy Markdown
Member Author

Do you want me to backport this to 3.11 as well?

hugovk commented Apr 14, 2023

Copy link
Copy Markdown
Member

Yes please, could be useful there too :)

carljm added a commit to carljm/cpython that referenced this pull request Apr 14, 2023
Merge branch 'main' into superopt
64da49f 
* main:
  pythongh-103532: Remove TKINTER_PROTECT_LOADTK code (pythonGH-103535)
  pythongh-103180: Add CI timeouts to all GitHub Actions jobs (python#103437)
  Remove double space in import error message (python#103458)
  ipaddress: Remove non-existent ip_str param from docstring (python#103461)
  Fix syntax typo in isolating extensions doc (python#103516)
  pythongh-103406: Modernize pos-only arguments usage in `test_signature` (python#103407)
  Proofread howto/perf_profiling.rst (python#103530)
  Fix unused functions warnings in instrumentation.c (pythonGH-103515)
sobolevn added a commit to sobolevn/cpython that referenced this pull request Apr 14, 2023
[3.11] pythongh-103180: Add CI timeouts to all GitHub Actions jobs (p…
f7e8ca1 
…ythonGH-103437).

(cherry picked from commit be8903e)

Co-authored-by: Nikita Sobolev <mail@sobolevn.me>

bedevere-bot commented Apr 14, 2023

Copy link
Copy Markdown

GH-103543 is a backport of this pull request to the 3.11 branch.

bedevere-bot removed the needs backport to 3.11 only security fixes label Apr 14, 2023
carljm added a commit to carljm/cpython that referenced this pull request Apr 14, 2023
Merge branch 'superopt' into superopt_spec
b73cff0 
* superopt:
  fix incompatible types
  update generated cases
  don't unnecessarily re-find args in error case
  Apply suggestions from code review
  pythongh-103532: Remove TKINTER_PROTECT_LOADTK code (pythonGH-103535)
  pythongh-103180: Add CI timeouts to all GitHub Actions jobs (python#103437)
  Remove double space in import error message (python#103458)
  ipaddress: Remove non-existent ip_str param from docstring (python#103461)
  Fix syntax typo in isolating extensions doc (python#103516)
  pythongh-103406: Modernize pos-only arguments usage in `test_signature` (python#103407)
  Proofread howto/perf_profiling.rst (python#103530)
  Fix unused functions warnings in instrumentation.c (pythonGH-103515)
hugovk pushed a commit that referenced this pull request Apr 15, 2023
[3.11] gh-103180: Add CI timeouts to all GitHub Actions jobs (GH-103437…
a3242c7 
…). (#103543)
hugovk mentioned this pull request Apr 20, 2023
Closed
AA-Turner mentioned this pull request Feb 20, 2025
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

hugovk hugovk approved these changes
hauntsaninja hauntsaninja approved these changes
ezio-melotti Awaiting requested review from ezio-melotti ezio-melotti is a code owner

Assignees

hugovk

Labels

build The build process and cross-build skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

Back | FazBrowse Home | New Git URL