FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

GH-103082: Code cleanup from review. by markshannon · Pull Request #103474 · python/cpython · GitHub

/ cpython Public

GH-103082: Code cleanup from review. - #103474

Merged
JelleZijlstra merged 2 commits into
python:mainfrom
faster-cpython:pep-669-review
Apr 29, 2023
ConversationCommits (2)ChecksFiles changed
Merged

GH-103082: Code cleanup from review.#103474
JelleZijlstra merged 2 commits into
python:mainfrom
faster-cpython:pep-669-review

Conversation

markshannon commented Apr 12, 2023 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Member

markshannon changed the title Code cleanup GH-103082: Code cleanup from review. Apr 12, 2023
bedevere-bot mentioned this pull request Apr 12, 2023
Closed
4 tasks
markshannon marked this pull request as ready for review April 12, 2023 13:07
Fidget-Spinner reviewed Apr 12, 2023
View reviewed changes
Comment thread Python/instrumentation.c Outdated
erlend-aasland reviewed Apr 13, 2023
View reviewed changes
Comment thread Python/instrumentation.c Outdated
Comment thread Python/instrumentation.c Outdated
Comment thread Python/instrumentation.c Outdated

JelleZijlstra commented Apr 29, 2023

Copy link
Copy Markdown
Member

I'm not sure why I can't merge this, maybe @Fidget-Spinner has to approve explicitly?

JelleZijlstra enabled auto-merge (squash) April 29, 2023 03:35
auto-merge was automatically disabled April 29, 2023 04:23

Pull request was closed

JelleZijlstra reopened this Apr 29, 2023
JelleZijlstra enabled auto-merge (squash) April 29, 2023 04:24
JelleZijlstra merged commit 738c226 into python:main Apr 29, 2023
markshannon deleted the pep-669-review branch September 26, 2023 12:55
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

JelleZijlstra JelleZijlstra approved these changes
erlend-aasland erlend-aasland approved these changes
Fidget-Spinner Fidget-Spinner approved these changes

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

Back | FazBrowse Home | New Git URL