FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-103650: Fix perf maps address format by art049 · Pull Request #103651 · python/cpython · GitHub

/ cpython Public

gh-103650: Fix perf maps address format - #103651

Merged
pablogsal merged 2 commits into
python:mainfrom
art049:fix/perf-maps-format
May 7, 2023
ConversationCommits (2)ChecksFiles changed
Merged

gh-103650: Fix perf maps address format#103651
pablogsal merged 2 commits into
python:mainfrom
art049:fix/perf-maps-format

Conversation

art049 commented Apr 20, 2023 •
edited by arhadthedev
Loading

Copy link
Copy Markdown
Contributor

bedevere-bot commented Apr 20, 2023

Copy link
Copy Markdown

Most changes to Python require a NEWS entry.

Please add it using the blurb_it web app or the blurb command-line tool.

bedevere-bot mentioned this pull request Apr 20, 2023
Closed

ghost commented Apr 20, 2023 •
edited by ghost
Loading

Copy link
Copy Markdown

All commit authors signed the Contributor License Agreement.

art049 force-pushed the fix/perf-maps-format branch from 6cb2f11 to 8af8b2b Compare April 20, 2023 16:15

bedevere-bot commented Apr 20, 2023

Copy link
Copy Markdown

Most changes to Python require a NEWS entry.

Please add it using the blurb_it web app or the blurb command-line tool.

art049 force-pushed the fix/perf-maps-format branch from ddc2b2d to 5df35f0 Compare April 20, 2023 16:25
sunmy2019 requested changes Apr 20, 2023
View reviewed changes
Comment thread Python/perf_trampoline.c Outdated
arhadthedev added interpreter-core (Objects, Python, Grammar, and Parser dirs) 3.11 only security fixes 3.12 only security fixes labels Apr 20, 2023
art049 force-pushed the fix/perf-maps-format branch from db8707f to 4e43459 Compare April 20, 2023 17:14
art049 force-pushed the fix/perf-maps-format branch from 4e43459 to 0ba49e2 Compare April 20, 2023 17:55
terryjreedy requested a review from pablogsal April 20, 2023 18:45

terryjreedy commented Apr 20, 2023

Copy link
Copy Markdown
Member

I think that this should wait until Pablo verifies that it is indeed the implementation that should be changed.

carljm commented May 5, 2023

Copy link
Copy Markdown
Member

@art049 did you verify that the new output after this PR works the same with perf?

@terryjreedy since the relevant docs here are the external perf map specification, not the CPython docs, it seems clear that the implementation in CPython should match the specification. There is no option to change the specification, we don't own it.

art049 commented May 5, 2023

Copy link
Copy Markdown
Contributor Author

@art049 did you verify that the new output after this PR works the same with perf?

Yes, also there are existing tests checking this:

cpython/Lib/test/test_perf_profiler.py

Lines 304 to 327 in 0ba49e2

def test_python_calls_appear_in_the_stack_if_perf_activated(self):
with temp_dir() as script_dir:
code = """if 1:
def foo(n):
x = 0
for i in range(n):
x += i
def bar(n):
foo(n)
def baz(n):
bar(n)
baz(10000000)
"""
script = make_script(script_dir, "perftest", code)
stdout, stderr = run_perf(script_dir, sys.executable, "-Xperf", script)
self.assertEqual(stderr, "")
self.assertIn(f"py::foo:{script}", stdout)
self.assertIn(f"py::bar:{script}", stdout)
self.assertIn(f"py::baz:{script}", stdout)

pablogsal added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label May 7, 2023

bedevere-bot commented May 7, 2023

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @pablogsal for commit 0ba49e2 🤖

If you want to schedule another build, you need to add the 🔨 test-with-buildbots label again.

bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label May 7, 2023

pablogsal commented May 7, 2023

Copy link
Copy Markdown
Member

Running this PR with the buildbots as the perf stuff is not checked on regular CI.

pablogsal merged commit 8d95012 into python:main May 7, 2023
jbower-fb pushed a commit to jbower-fb/cpython that referenced this pull request May 8, 2023
pythongh-103650: Fix perf maps address format (python#103651)
44914e0
carljm added a commit to carljm/cpython that referenced this pull request May 9, 2023
Merge branch 'main' into inlinecomp2
76077cd 
* main: (47 commits)
  pythongh-97696 Remove unnecessary check for eager_start kwarg (python#104188)
  pythonGH-104308: socket.getnameinfo should release the GIL (python#104307)
  pythongh-104310: Add importlib.util.allowing_all_extensions() (pythongh-104311)
  pythongh-99113: A Per-Interpreter GIL! (pythongh-104210)
  pythonGH-104284: Fix documentation gettext build (python#104296)
  pythongh-89550: Buffer GzipFile.write to reduce execution time by ~15% (python#101251)
  pythongh-104223: Fix issues with inheriting from buffer classes (python#104227)
  pythongh-99108: fix typo in Modules/Setup (python#104293)
  pythonGH-104145: Use fully-qualified cross reference types for the bisect module (python#104172)
  pythongh-103193: Improve `getattr_static` test coverage (python#104286)
  Trim trailing whitespace and test on CI (python#104275)
  pythongh-102500: Remove mention of bytes shorthand (python#104281)
  pythongh-97696: Improve and fix documentation for asyncio eager tasks (python#104256)
  pythongh-99108: Replace SHA3 implementation HACL* version (python#103597)
  pythongh-104273: Remove redundant len() calls in argparse function (python#104274)
  pythongh-64660: Don't hardcode Argument Clinic return converter result variable name (python#104200)
  pythongh-104265 Disallow instantiation of `_csv.Reader` and `_csv.Writer` (python#104266)
  pythonGH-102613: Improve performance of `pathlib.Path.rglob()` (pythonGH-104244)
  pythongh-103650: Fix perf maps address format (python#103651)
  pythonGH-89812: Churn `pathlib.Path` methods (pythonGH-104243)
  ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

sunmy2019 sunmy2019 requested changes
pablogsal pablogsal approved these changes

Assignees

No one assigned

Labels

3.11 only security fixes 3.12 only security fixes interpreter-core (Objects, Python, Grammar, and Parser dirs)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

Back | FazBrowse Home | New Git URL