FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-103810: Fix broken references in dataclasses by olgarithms · Pull Request #103811 · python/cpython · GitHub

  1. python
  2. cpython

Repository navigation

gh-103810: Fix broken references in dataclasses - #103811

Merged
ambv merged 2 commits into
python:mainfrom
olgarithms:fix-issue-103810
Apr 24, 2023
ConversationCommits (2)ChecksFiles changed
Merged

gh-103810: Fix broken references in dataclasses#103811
ambv merged 2 commits into
python:mainfrom
olgarithms:fix-issue-103810

Conversation

olgarithms commented Apr 24, 2023 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Contributor

olgarithms requested a review from ericvsmith as a code owner April 24, 2023 22:45

bedevere-bot commented Apr 24, 2023

Copy link
Copy Markdown

Most changes to Python require a NEWS entry.

Please add it using the blurb_it web app or the blurb command-line tool.

bedevere-bot mentioned this pull request Apr 24, 2023
Closed

ghost commented Apr 24, 2023 •
edited by ghost
Loading

Copy link
Copy Markdown

All commit authors signed the Contributor License Agreement.

hugovk reviewed Apr 24, 2023
View reviewed changes
Comment thread Doc/library/dataclasses.rst Outdated
Remove extra .
a81eca8 
Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>
ambv added docs Documentation in the Doc dir needs backport to 3.11 only security fixes labels Apr 24, 2023
ambv merged commit 0f23eda into python:main Apr 24, 2023

miss-islington commented Apr 24, 2023

Copy link
Copy Markdown
Contributor

Thanks @olgarithms for the PR, and @ambv for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖

miss-islington commented Apr 24, 2023

Copy link
Copy Markdown
Contributor

Sorry @olgarithms and @ambv, I had trouble checking out the 3.11 backport branch.
Please retry by removing and re-adding the "needs backport to 3.11" label.
Alternatively, you can backport using cherry_picker on the command line.
cherry_picker 0f23eda4b996dacd19dbe91bd47a30433bf236d2 3.11

ambv added needs backport to 3.11 only security fixes and removed needs backport to 3.11 only security fixes labels Apr 24, 2023

miss-islington commented Apr 24, 2023

Copy link
Copy Markdown
Contributor

Thanks @olgarithms for the PR, and @ambv for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖

miss-islington commented Apr 24, 2023

Copy link
Copy Markdown
Contributor

Sorry, @olgarithms and @ambv, I could not cleanly backport this to 3.11 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 0f23eda4b996dacd19dbe91bd47a30433bf236d2 3.11

ambv pushed a commit to ambv/cpython that referenced this pull request Apr 24, 2023
[3.11] pythongh-103810: Fix broken references in dataclasses (pythonG…
319ab15 
…H-103811)

Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>
(cherry picked from commit 0f23eda)

Co-authored-by: Olga Matoula <olgamatoula@gmail.com>

bedevere-bot commented Apr 24, 2023

Copy link
Copy Markdown

GH-103813 is a backport of this pull request to the 3.11 branch.

bedevere-bot removed the needs backport to 3.11 only security fixes label Apr 24, 2023
ambv added a commit that referenced this pull request Apr 24, 2023
[3.11] gh-103810: Fix broken references in dataclasses (GH-103811) (#…
56d50dd 
…103813)

(cherry picked from commit 0f23eda)

Co-authored-by: Olga Matoula <olgamatoula@gmail.com>
olgarithms deleted the fix-issue-103810 branch April 24, 2023 23:41
olgarithms mentioned this pull request Apr 25, 2023
Merged

hugovk commented Apr 25, 2023

Copy link
Copy Markdown
Member

@olgarithms Thank you very much and congratulations on merging your first pull request to CPython! 🧁🥂🎈

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

hugovk hugovk left review comments
ericvsmith Awaiting requested review from ericvsmith ericvsmith is a code owner

Assignees

ambv

Labels

docs Documentation in the Doc dir skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

Back | FazBrowse Home | New Git URL