gh-102950: Adjust tarfile filter tests for systems that don't set the sticky bit - #103831
Merged
encukou merged 2 commits intoApr 25, 2023
Merged
gh-102950: Adjust tarfile filter tests for systems that don't set the sticky bit#103831encukou merged 2 commits into
encukou merged 2 commits into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Also remove expilcit `type=tarfile.DIRTYPE`, the slash at the end is enough.
Copy link
Copy Markdown
Contributor
|
I tried the patch on Solaris and the test suite is green again. Thanks! |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
|
Hm, Sir Bedevere got stuck figuring out whether the pull request title starts with gh-####. Quite in character for a Monty Python character! |
Sorry, something went wrong.
encukou
added a commit
to encukou/cpython
that referenced
this pull request
Apr 25, 2023
…et the sticky bit (pythonGH-103831) Also remove expilcit `type=tarfile.DIRTYPE`, the slash at the end is enough. Backport of c8c3956
mcepl
pushed a commit
to openSUSE-Python/cpython
that referenced
this pull request
May 3, 2023
…et the sticky bit (pythonGH-103831) Also remove expilcit `type=tarfile.DIRTYPE`, the slash at the end is enough. Backport of c8c3956
encukou
added a commit
to encukou/cpython
that referenced
this pull request
May 11, 2023
…et the sticky bit (pythonGH-103831) Also remove expilcit `type=tarfile.DIRTYPE`, the slash at the end is enough. Backport of c8c3956
encukou
added a commit
to encukou/cpython
that referenced
this pull request
May 11, 2023
…et the sticky bit (pythonGH-103831) Also remove expilcit `type=tarfile.DIRTYPE`, the slash at the end is enough. Backport of c8c3956
encukou
added a commit
to encukou/cpython
that referenced
this pull request
May 16, 2023
…et the sticky bit (pythonGH-103831) Also remove expilcit `type=tarfile.DIRTYPE`, the slash at the end is enough. Backport of c8c3956
encukou
added a commit
to encukou/cpython
that referenced
this pull request
May 30, 2023
…et the sticky bit (pythonGH-103831) Also remove expilcit `type=tarfile.DIRTYPE`, the slash at the end is enough. Backport of c8c3956
mcepl
pushed a commit
to openSUSE-Python/cpython
that referenced
this pull request
Mar 28, 2024
…et the sticky bit (pythonGH-103831) Also remove expilcit `type=tarfile.DIRTYPE`, the slash at the end is enough. Backport of c8c3956
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also remove expilcit type=tarfile.DIRTYPE, the slash at the end is enough.
@kulikjak, could you check this on a Solaris or FreeBSD box?