FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-103636: issue warning for deprecated calendar constants by Agent-Hellboy · Pull Request #103833 · python/cpython · GitHub

/ cpython Public

gh-103636: issue warning for deprecated calendar constants - #103833

Merged
hugovk merged 21 commits into
python:mainfrom
Agent-Hellboy:raise-warning-in-calendar-mod
Apr 29, 2023
ConversationCommits (21)ChecksFiles changed
Merged

gh-103636: issue warning for deprecated calendar constants#103833
hugovk merged 21 commits into
python:mainfrom
Agent-Hellboy:raise-warning-in-calendar-mod

Conversation

Agent-Hellboy commented Apr 25, 2023 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Contributor

bedevere-bot mentioned this pull request Apr 26, 2023
Closed
arhadthedev added the stdlib Standard Library Python modules in the Lib/ directory label Apr 26, 2023
hugovk requested changes Apr 26, 2023
View reviewed changes

hugovk left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Please could you add a NEWS file and document the deprecation at https://docs.python.org/3.12/whatsnew/3.12.html#deprecated?

Comment thread Lib/calendar.py Outdated
Comment thread Lib/calendar.py Outdated
Comment thread Lib/calendar.py Outdated
Comment thread Lib/calendar.py Outdated
Comment thread Lib/calendar.py Outdated
Comment thread Lib/test/test_calendar.py Outdated

bedevere-bot commented Apr 26, 2023

Copy link
Copy Markdown

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

merwok reviewed Apr 26, 2023
View reviewed changes
Comment thread Lib/test/test_calendar.py Outdated

Agent-Hellboy commented Apr 26, 2023

Copy link
Copy Markdown
Contributor Author

I have made the requested changes; please review again

bedevere-bot commented Apr 26, 2023

Copy link
Copy Markdown

Thanks for making the requested changes!

@hugovk: please review the changes made to this pull request.

bedevere-bot requested a review from hugovk April 26, 2023 18:42
merwok reviewed Apr 26, 2023
View reviewed changes
Comment thread Doc/whatsnew/3.12.rst Outdated
merwok reviewed Apr 26, 2023
View reviewed changes
Comment thread Lib/calendar.py Outdated
Comment thread Lib/calendar.py Outdated
Comment thread Lib/calendar.py
Comment thread Lib/test/test_calendar.py Outdated
Comment thread Misc/NEWS.d/next/Library/2023-04-26-18-12-13.gh-issue-103636.-KvCgO.rst Outdated
merwok reviewed Apr 26, 2023
View reviewed changes
Comment thread Doc/library/calendar.rst Outdated

Agent-Hellboy commented Apr 27, 2023

Copy link
Copy Markdown
Contributor Author

sorry for the silly mistakes, I have made the requested changes; please review again

bedevere-bot commented Apr 27, 2023

Copy link
Copy Markdown

Thanks for making the requested changes!

@hugovk: please review the changes made to this pull request.

hugovk requested changes Apr 27, 2023
View reviewed changes

hugovk left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Tip: You can directly apply all the suggestions you want in one go with Files changed -> Add to batch -> Commit

Comment thread Doc/whatsnew/3.12.rst Outdated
Comment thread Misc/NEWS.d/next/Library/2023-04-26-18-12-13.gh-issue-103636.-KvCgO.rst Outdated
Comment thread Doc/whatsnew/3.12.rst Outdated
Comment thread Doc/whatsnew/3.12.rst Outdated

bedevere-bot commented Apr 27, 2023

Copy link
Copy Markdown

Thanks for making the requested changes!

@hugovk: please review the changes made to this pull request.

bedevere-bot requested a review from hugovk April 27, 2023 12:40
merwok reviewed Apr 27, 2023
View reviewed changes
Comment thread Doc/whatsnew/3.12.rst Outdated
merwok reviewed Apr 27, 2023
View reviewed changes
Comment thread Doc/whatsnew/3.12.rst Outdated
Agent-Hellboy and others added 3 commits April 27, 2023 20:14
Update Doc/whatsnew/3.12.rst
49079d1 
Co-authored-by: Éric <merwok@netwok.org>
Update Doc/whatsnew/3.12.rst
db53e78 
Co-authored-by: Éric <merwok@netwok.org>
fix doc
9c289c5
merwok changed the title gh-103636: raise warning for January and February attribute gh-103636: issue warning for deprecated calendar constants Apr 27, 2023
merwok added 3.12 only security fixes awaiting core review and removed awaiting merge labels Apr 27, 2023
hugovk requested changes Apr 28, 2023
View reviewed changes

hugovk left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Thanks, almost there!

Comment thread Doc/library/calendar.rst
Comment thread Doc/library/calendar.rst

bedevere-bot commented Apr 28, 2023

Copy link
Copy Markdown

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

Agent-Hellboy and others added 2 commits April 28, 2023 09:23
Update Doc/library/calendar.rst
7ec1945 
Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>
Update Doc/library/calendar.rst
7628f11 
Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>
hugovk approved these changes Apr 28, 2023
View reviewed changes

hugovk left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Thank you!

hugovk merged commit 84e7d0f into python:main Apr 29, 2023
carljm added a commit to carljm/cpython that referenced this pull request May 1, 2023
Merge branch 'main' into supermon
159b2aa 
* main: (26 commits)
  pythongh-104028: Reduce object creation while calling callback function from gc (pythongh-104030)
  pythongh-104036: Fix direct invocation of test_typing (python#104037)
  pythongh-102213: Optimize the performance of `__getattr__` (pythonGH-103761)
  pythongh-103895: Improve how invalid `Exception.__notes__` are displayed (python#103897)
  Adjust expression from `==` to `!=` in alignment with the meaning of the paragraph. (pythonGH-104021)
  pythongh-88496: Fix IDLE test hang on macOS (python#104025)
  Improve int test coverage (python#104024)
  pythongh-88773: Added teleport method to Turtle library (python#103974)
  pythongh-104015: Fix direct invocation of `test_dataclasses` (python#104017)
  pythongh-104012: Ensure test_calendar.CalendarTestCase.test_deprecation_warning consistently passes (python#104014)
  pythongh-103977: compile re expressions in platform.py only if required (python#103981)
  pythongh-98003: Inline call frames for CALL_FUNCTION_EX (pythonGH-98004)
  Replace Netlify with Read the Docs build previews (python#103843)
  Update name in acknowledgements and add mailmap (python#103696)
  pythongh-82054: allow test runner to split test_asyncio to execute in parallel by sharding. (python#103927)
  Remove non-existing tools from Sundry skiplist (python#103991)
  pythongh-103793: Defer formatting task name (python#103767)
  pythongh-87092: change assembler to use instruction sequence instead of CFG (python#103933)
  pythongh-103636: issue warning for deprecated calendar constants (python#103833)
  Various small fixes to dis docs (python#103923)
  ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

merwok merwok approved these changes
hugovk hugovk approved these changes

Assignees

hugovk

Labels

3.12 only security fixes stdlib Standard Library Python modules in the Lib/ directory

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

Back | FazBrowse Home | New Git URL