FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-103879: Fix refleak in super specialization by JelleZijlstra · Pull Request #103882 · python/cpython · GitHub

/ cpython Public

gh-103879: Fix refleak in super specialization - #103882

Merged
JelleZijlstra merged 1 commit into
python:mainfrom
JelleZijlstra:fixref
Apr 26, 2023
ConversationCommits (1)ChecksFiles changed
Merged

gh-103879: Fix refleak in super specialization#103882
JelleZijlstra merged 1 commit into
python:mainfrom
JelleZijlstra:fixref

Conversation

JelleZijlstra commented Apr 26, 2023 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Member

JelleZijlstra added the 🔨 test-with-refleak-buildbots Test PR w/ refleak buildbots; report in status section label Apr 26, 2023
JelleZijlstra requested a review from carljm April 26, 2023 14:53

bedevere-bot commented Apr 26, 2023

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @JelleZijlstra for commit fb53869 🤖

If you want to schedule another build, you need to add the 🔨 test-with-refleak-buildbots label again.

bedevere-bot removed the 🔨 test-with-refleak-buildbots Test PR w/ refleak buildbots; report in status section label Apr 26, 2023
bedevere-bot mentioned this pull request Apr 26, 2023
Closed
carljm approved these changes Apr 26, 2023
View reviewed changes

carljm left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Ugh, sorry about this and for wasting so much of your time tracking these down on your PEP 695 work yesterday!

I thought I'd run the refleak buildbots on the specialization PR, not sure what happened. I think maybe I triggered them but the buildbot fleet was backed up, and so they didn't actually start running for a long time, and then I later rebased the PR again assuming they had run and passed? Will be more careful checking that in future.

Your changes here look correct to me, since the res cached in the inline cache should be a borrowed reference (as noted in the comment), not a strong reference.

Approving, assuming the signal all looks green.

JelleZijlstra mentioned this pull request Apr 26, 2023
Merged

JelleZijlstra commented Apr 26, 2023

Copy link
Copy Markdown
Member Author

I think there may be an issue where the default buildbot run doesn't include the refleak buildbots. If you look at the commits on github.com/python/cpython, the most recent ones are green, even though the buildbot website shows the refleak buildbots failing on main.

JelleZijlstra commented Apr 26, 2023

Copy link
Copy Markdown
Member Author

Also, I now understand why my refleaks kept going away if I removed one too many lines: if the refleak is triggered on specialization, it only manifests if the code gets run enough times.

carljm mentioned this pull request Apr 26, 2023
Merged
JelleZijlstra merged commit 6c4124d into python:main Apr 26, 2023
JelleZijlstra deleted the fixref branch April 26, 2023 15:50
itamaro pushed a commit to itamaro/cpython that referenced this pull request Apr 26, 2023
pythongh-103879: Fix refleak in super specialization (python#103882)
c51531c
JelleZijlstra restored the fixref branch September 10, 2024 23:37
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

carljm carljm approved these changes
Fidget-Spinner Fidget-Spinner approved these changes

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

Back | FazBrowse Home | New Git URL