FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

GH-103903: Test the minimum Sphinx version in CI by AA-Turner · Pull Request #103904 · python/cpython · GitHub

  1. python
  2. cpython

Repository navigation

GH-103903: Test the minimum Sphinx version in CI - #103904

Merged
AlexWaygood merged 7 commits into
python:mainfrom
AA-Turner:docs-minimum-version
Apr 27, 2023
ConversationCommits (7)ChecksFiles changed
Merged

GH-103903: Test the minimum Sphinx version in CI#103904
AlexWaygood merged 7 commits into
python:mainfrom
AA-Turner:docs-minimum-version

Conversation

AA-Turner commented Apr 26, 2023 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Member

bedevere-bot mentioned this pull request Apr 26, 2023
Closed
AA-Turner requested review from AlexWaygood and CAM-Gerlach and removed request for berkerpeksag and erlend-aasland April 26, 2023 22:56
erlend-aasland requested review from berkerpeksag and removed request for AlexWaygood and CAM-Gerlach April 26, 2023 22:57
AA-Turner added docs Documentation in the Doc dir needs backport to 3.11 only security fixes skip news labels Apr 26, 2023
AA-Turner mentioned this pull request Apr 26, 2023
Merged

AA-Turner commented Apr 26, 2023

Copy link
Copy Markdown
Member Author

@erlend-aasland -- were you just removing your own automatic review request, or did you mean to remove Alex & Cam too? The interface says we both edited at the same time so I wonder if there was clash -- just checking intentionality!

A

AlexWaygood commented Apr 26, 2023

Copy link
Copy Markdown
Member

(I'm happy to review, but have just boarded the first of two flights back to the UK, so my review might be a little delayed! :)

AA-Turner commented Apr 26, 2023

Copy link
Copy Markdown
Member Author

Safe journey!

erlend-aasland commented Apr 27, 2023

Copy link
Copy Markdown
Contributor

I only meant to remove myself. I don't know anything about the various Sphinx versions, sorry. I'm sure both CAM and Alex are much more competent reviewers than me, for this PR.

hugovk reviewed Apr 27, 2023
View reviewed changes
Comment thread .github/workflows/doc.yml Outdated
Comment thread .github/workflows/doc.yml Outdated

hugovk commented Apr 27, 2023

Copy link
Copy Markdown
Member

(I'm happy to review, but have just boarded the first of two flights back to the UK, so my review might be a little delayed! :)

Excuses, excuses! ;) Welcome home!

AA-Turner commented Apr 27, 2023

Copy link
Copy Markdown
Member Author

I only meant to remove myself. I don't know anything about the various Sphinx versions, sorry.

No worries, I just wanted to check lest you'd had discussions in person!

A

AA-Turner requested a review from AlexWaygood April 27, 2023 12:42

AA-Turner commented Apr 27, 2023

Copy link
Copy Markdown
Member Author

I didn't expect the Spanish inquisition!

bedevere-bot commented Apr 27, 2023

Copy link
Copy Markdown

Nobody expects the Spanish Inquisition!

: please review the changes made to this pull request.

AA-Turner commented Apr 27, 2023

Copy link
Copy Markdown
Member Author

Oh, does Sir Bedevere not recognise a regular 'comment' review?

A

hugovk reviewed Apr 27, 2023
View reviewed changes

hugovk left a comment •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Oh, does Sir Bedevere not recognise a regular 'comment' review?

PR looks good now, but just testing this out... Want to try it again?

AA-Turner commented Apr 27, 2023

Copy link
Copy Markdown
Member Author

I didn't expect the Spanish inquisition!

bedevere-bot commented Apr 27, 2023

Copy link
Copy Markdown

Nobody expects the Spanish Inquisition!

: please review the changes made to this pull request.

AA-Turner commented Apr 27, 2023

Copy link
Copy Markdown
Member Author

Same result -- I'd guess that he picks up the key-phrase but doesn't recognise who to ping for a re-review?

A

AlexWaygood approved these changes Apr 27, 2023
View reviewed changes

AlexWaygood left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

This LGTM! Thanks @AA-Turner

AlexWaygood merged commit 44b5c21 into python:main Apr 27, 2023

miss-islington commented Apr 27, 2023

Copy link
Copy Markdown
Contributor

Thanks @AA-Turner for the PR, and @AlexWaygood for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖

miss-islington commented Apr 27, 2023

Copy link
Copy Markdown
Contributor

Sorry, @AA-Turner and @AlexWaygood, I could not cleanly backport this to 3.11 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 44b5c21f4124f9fa1312fada313c80c6abfa6d49 3.11

AlexWaygood commented Apr 27, 2023

Copy link
Copy Markdown
Member

@AA-Turner, can I leave the backport in your capable hands? :)

AA-Turner commented Apr 27, 2023

Copy link
Copy Markdown
Member Author

@AA-Turner, can I leave the backport in your capable hands? :)

Yessir, just having dinner though -- will do later this eve!

A

AlexWaygood assigned AA-Turner and unassigned AlexWaygood Apr 27, 2023
AA-Turner added a commit to AA-Turner/cpython that referenced this pull request Apr 27, 2023
[3.11] pythonGH-103903: Test the minimum Sphinx version in CI (python…
5359efe 
…GH-103904).

(cherry picked from commit 44b5c21)

Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
AA-Turner added a commit to AA-Turner/cpython that referenced this pull request Apr 27, 2023
pythonGH-103903: Test the minimum Sphinx version in CI (python#103904)
5ca3cf9 
(cherry picked from commit 44b5c21)
AA-Turner added a commit to AA-Turner/cpython that referenced this pull request Apr 27, 2023
[3.11] pythonGH-103903: Test the minimum Sphinx version in CI (python…
8749b80 
…GH-103904).

(cherry picked from commit 44b5c21)

Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
AA-Turner added a commit to AA-Turner/cpython that referenced this pull request Apr 27, 2023
[3.11] pythonGH-103903: Test the minimum Sphinx version in CI (python…
d255ecc 
…GH-103904).

(cherry picked from commit 44b5c21)

Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>

bedevere-bot commented Apr 27, 2023

Copy link
Copy Markdown

GH-103948 is a backport of this pull request to the 3.11 branch.

bedevere-bot removed the needs backport to 3.11 only security fixes label Apr 27, 2023
AlexWaygood pushed a commit that referenced this pull request Apr 27, 2023
[3.11] GH-103903: Test the minimum Sphinx version in CI (#103904) (#1…
dbc44fa 
…03948)

[3.11] GH-103903: Test the minimum Sphinx version in CI (GH-103904).

(cherry picked from commit 44b5c21)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

hugovk hugovk left review comments
AlexWaygood AlexWaygood approved these changes
ezio-melotti Awaiting requested review from ezio-melotti ezio-melotti is a code owner

Assignees

AA-Turner

Labels

docs Documentation in the Doc dir skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

Back | FazBrowse Home | New Git URL