FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-103092: Adapt _ctypes's PyCStgDict type to heap type by erlend-aasland · Pull Request #103932 · python/cpython · GitHub

/ cpython Public

gh-103092: Adapt _ctypes's PyCStgDict type to heap type - #103932

Closed
erlend-aasland wants to merge 3 commits into
python:mainfrom
erlend-aasland:isolate-ctypes/part2-take2
ConversationCommits (3)ChecksFiles changed
Closed

gh-103092: Adapt _ctypes's PyCStgDict type to heap type#103932
erlend-aasland wants to merge 3 commits into
python:mainfrom
erlend-aasland:isolate-ctypes/part2-take2

Conversation

erlend-aasland commented Apr 27, 2023 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Contributor

Port PyCStgDict_Type to heap type.

bedevere-bot mentioned this pull request Apr 27, 2023
Closed
25 tasks

erlend-aasland commented Apr 27, 2023 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

This probably fails because of the dict hacks in StructUnionType_new (wild guess).

corona10 self-requested a review April 27, 2023 23:31
kumaraditya303 force-pushed the isolate-ctypes/part2-take2 branch from 11c91c9 to 56fd7e9 Compare May 15, 2023 09:49

kumaraditya303 commented May 30, 2023 •
edited
Loading

Copy link
Copy Markdown
Contributor

While I am still trying to figure out where it breaks, you may proceed to port other simpler types (if there are any).

vstinner commented Jul 12, 2023

Copy link
Copy Markdown
Member

What's the status of this PR? Is it ready for review? It's still marked as a draft.

neonene reviewed Jan 4, 2024
View reviewed changes
Comment thread Modules/_ctypes/stgdict.c
PyCStgDict_traverse(StgDictObject *self, visitproc visit, void *arg)
{
Py_VISIT(Py_TYPE(self));
Py_VISIT(self->proto);

neonene Jan 4, 2024

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Maybe an extra visit to the proto member? The CDataType_traverse function in _ctypes.c has an explicit Py_VISIT(dict->proto).

erlend-aasland changed the title gh-103092: Isolate _ctypes, part 2 gh-103092: Adapt _ctypes.PyCStgDict_Type to heap type Jan 9, 2024
erlend-aasland changed the title gh-103092: Adapt _ctypes.PyCStgDict_Type to heap type gh-103092: Adapt _ctypes's PyCStgDict type to heap type Jan 9, 2024

erlend-aasland commented Jan 9, 2024

Copy link
Copy Markdown
Contributor Author

I don't have the bandwidth to follow up this right now; abandoning this PR.

erlend-aasland deleted the isolate-ctypes/part2-take2 branch January 9, 2024 21:47
vstinner mentioned this pull request Jan 19, 2024
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

kumaraditya303 Awaiting requested review from kumaraditya303
corona10 Awaiting requested review from corona10
ericsnowcurrently Awaiting requested review from ericsnowcurrently ericsnowcurrently will be requested when the pull request is marked ready for review ericsnowcurrently is a code owner
1 more reviewer
neonene neonene left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

awaiting core review skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

Back | FazBrowse Home | New Git URL