Repository navigation
[3.11] gh-103971: Fix wrong line number generated for match-case blocks - #103980
Merged
brandtbucher merged 4 commits intoApr 28, 2023
Merged
brandtbucher merged 4 commits into
brandtbucher merged 4 commits into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
gaogaotiantian
requested review from
brandtbucher and
markshannon
as code owners
April 28, 2023 18:56
…3-04-28-18-57-13.gh-issue-103971.Q3U9lv.rst
brandtbucher
approved these changes
Apr 28, 2023
brandtbucher
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Thanks for the quick fix (and welcome to the compiler)!
Sorry, something went wrong.
Comment thread
Misc/NEWS.d/next/Core and Builtins/2023-04-28-18-57-13.gh-issue-103971.Q3U9lv.rst
Outdated
brandtbucher
enabled auto-merge (squash)
April 28, 2023 19:27
Copy link
Copy Markdown
Member
Author
|
Thank you for the guidance! |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
Can you open a PR with just the new test against main? |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
Assignees
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The residue location issue would cause the case block setting the line number of RETURN_VALUE to the code block just parsed, which confuses debugger to believe the last line of the code block was executed even though it was not.