gh-68395: Avoid naming conflicts by mangling variable names in Argument Clinic - #104065
Merged
erlend-aasland merged 1 commit intoMay 5, 2023
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
…Argument Clinic Add all internally used variable names to CLINIC_PREFIXED_ARGS.
erlend-aasland
force-pushed
the
clinic-mangle-more-names
branch
from
8acfbe7 to
9a74d01
Compare
May 1, 2023 21:45
Copy link
Copy Markdown
Contributor
Author
|
We can skip NEWS here; this is an implementation detail of the internal tooling. |
Sorry, something went wrong.
erlend-aasland
enabled auto-merge (squash)
May 1, 2023 21:51
erlend-aasland
disabled auto-merge
May 1, 2023 21:51
hauntsaninja
approved these changes
May 2, 2023
Copy link
Copy Markdown
Contributor
Author
|
I'll wait a few days to give Serhiy a chance to chime in, before merging this. |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
|
@serhiy-storchaka, I aim on landing this by tomorrow evening (CET). |
Sorry, something went wrong.
kumaraditya303
approved these changes
May 5, 2023
This was
linked to
issues
May 5, 2023
Copy link
Copy Markdown
Contributor
Author
|
Two green lights, no complaints; I'm landing this. Thanks for the reviews! |
Sorry, something went wrong.
carljm
added a commit
to carljm/cpython
that referenced
this pull request
May 5, 2023
* main: (61 commits) pythongh-64595: Argument Clinic: Touch source file if any output file changed (python#104152) pythongh-64631: Test exception messages in cloned Argument Clinic funcs (python#104167) pythongh-68395: Avoid naming conflicts by mangling variable names in Argument Clinic (python#104065) pythongh-64658: Expand Argument Clinic return converter docs (python#104175) pythonGH-103092: port `_asyncio` freelist to module state (python#104196) pythongh-104051: fix crash in test_xxtestfuzz with -We (python#104052) pythongh-104190: fix ubsan crash (python#104191) pythongh-104106: Add gcc fallback of mkfifoat/mknodat for macOS (pythongh-104129) pythonGH-104142: Fix _Py_RefcntAdd to respect immortality (pythonGH-104143) pythongh-104112: link from cached_property docs to method-caching FAQ (python#104113) pythongh-68968: Correcting message display issue with assertEqual (python#103937) pythonGH-103899: Provide a hint when accidentally calling a module (pythonGH-103900) pythongh-103963: fix 'make regen-opcode' in out-of-tree builds (python#104177) pythongh-102500: Add PEP 688 and 698 to the 3.12 release highlights (python#104174) pythonGH-81079: Add case_sensitive argument to `pathlib.Path.glob()` (pythonGH-102710) pythongh-91896: Deprecate collections.abc.ByteString (python#102096) pythongh-99593: Add tests for Unicode C API (part 2) (python#99868) pythongh-102500: Document PEP 688 (python#102571) pythongh-102500: Implement PEP 688 (python#102521) pythongh-96534: socketmodule: support FreeBSD divert(4) socket (python#96536) ...
jbower-fb
pushed a commit
to jbower-fb/cpython
that referenced
this pull request
May 8, 2023
…Argument Clinic (python#104065) Add all internally used variable names to CLINIC_PREFIXED_ARGS.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
Assignees
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add all internally used variable names to CLINIC_PREFIXED_ARGS.