FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-104144: Skip scheduling a done callback if a TaskGroup task completes eagerly by itamaro · Pull Request #104140 · python/cpython · GitHub

/ cpython Public

gh-104144: Skip scheduling a done callback if a TaskGroup task completes eagerly #104140

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gvanrossum merged 6 commits into from
May 5, 2023
+9 −2
Conversation 7 Commits 6 Checks 0 Files changed 2
Merged

gh-104144: Skip scheduling a done callback if a TaskGroup task completes eagerly #104140

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
5397cd9
gh-NNNN: Skip scheduling a done callback if a TaskGroup task complete…
itamaro May 3, 2023
8d6a77e
Add NEWS entry
itamaro May 3, 2023
a125c1f
Apply review feedback to NEWS entry
itamaro May 4, 2023
dae3e06
Merge branch 'main' into taskgroups-skip-done-callback
itamaro May 5, 2023
161d0f8
revert skipping _set_task_name if name is None; fix typo in comment
itamaro May 5, 2023
2b98bd9
Merge branch 'main' into taskgroups-skip-done-callback
itamaro May 5, 2023
File filter

Filter by extension

Filter by extension .py  (1) .rst  (1) All 2 file types selected
Viewed files
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Unified
Split
Hide whitespace
Diff view
Unified
Split
Hide whitespace
10 changes: 8 additions & 2 deletions Lib/asyncio/taskgroups.py
Show comments
View file
Open in desktop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Original file line number Diff line number Diff line change
Expand Up @@ -164,8 +164,14 @@ def create_task(self, coro, *, name=None, context=None):
else:
task = self._loop.create_task(coro, context=context)
tasks._set_task_name(task, name)
task.add_done_callback(self._on_task_done)
self._tasks.add(task)
# optimization: Immediately call the done callback if the task is
# already done (e.g. if the coro was able to complete eagerly),
# and skip scheduling a done callback
if task.done():
self._on_task_done(task)
else:
self._tasks.add(task)
task.add_done_callback(self._on_task_done)
return task

# Since Python 3.8 Tasks propagate all exceptions correctly,
Expand Down
1 change: 1 addition & 0 deletions Misc/NEWS.d/next/Library/2023-05-03-16-51-53.gh-issue-104144.653Q0P.rst
Show comments
View file
Open in desktop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Optimize :class:`asyncio.TaskGroup` when using :func:`asyncio.eager_task_factory`. Skip scheduling done callbacks when all tasks finish without blocking.

kumaraditya303 May 6, 2023

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Hmm actually the scheduling is skipped on a per task basis rather than when all tasks finish without blocking.

itamaro May 7, 2023

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I have a fix in itamaro@ac1ee82 (PR depends on gh-104251 first)
Back | FazBrowse Home | New Git URL