Repository navigation
GH-103247: bypass the import cache on the _require_loader helper - #104186
Merged
FFY00 merged 2 commits intoAug 24, 2023
Merged
FFY00 merged 2 commits into
FFY00 merged 2 commits into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
This is not a fix for the importlib test monkeypatching leakage but it's something that we probably should be doing anyway. Signed-off-by: Filipe Laíns <lains@riseup.net>
FFY00
requested review from
brettcannon,
encukou,
ericsnowcurrently,
ncoghlan and
warsaw
as code owners
May 5, 2023 00:50
Copy link
Copy Markdown
Member
Author
|
cc @JelleZijlstra as the original reporter |
Sorry, something went wrong.
brettcannon
approved these changes
May 10, 2023
sunmy2019
approved these changes
May 10, 2023
Copy link
Copy Markdown
Member
Author
|
It seems this fell off mental work pool and I only noticed it now. Since we have approvals, I am gonna update the branch and schedule it for merging. |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
Bisection shows that the merge of this PR introduced a reference leak in test_import, so all refleak buildbots are red: #108696 |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
|
@carljm thanks for the catch, let's revert then. |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is not a fix for the importlib test monkeypatching leakage but it's something that we probably should be doing anyway.