gh-101819: Adapt _io.PyWindowsConsoleIO_Type to heap type - #104197
Merged
erlend-aasland merged 6 commits intoMay 7, 2023
Merged
gh-101819: Adapt _io.PyWindowsConsoleIO_Type to heap type#104197erlend-aasland merged 6 commits into
erlend-aasland merged 6 commits into
Conversation
erlend-aasland
requested review from
ericsnowcurrently,
kumaraditya303 and
vstinner
and removed request for
ericsnowcurrently
May 5, 2023 11:23
Copy link
Copy Markdown
Member
|
Is it a draft or ready for review? |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
FAIL: test_no_memleak (test.test_embed.MiscTests.test_no_memleak) (frozen_modules='on', stmt='import __hello__')
----------------------------------------------------------------------
Traceback (most recent call last):
File "D:\a\cpython\cpython\Lib\test\test_embed.py", line 1802, in test_no_memleak
self.assertEqual(refs, 0, out)
AssertionError: 512 != 0 : [512 refs, 302 blocks]
It seems like there is leak somewhere. |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
test_winconsoleio crashed (Exit code 3) -- running: test_multiprocessing_spawn (2 min 47 sec) A�s�s�e�r�t�i�o�n� �f�a�i�l�e�d�:� �P�y�O�b�j�e�c�t�_�T�y�p�e�C�h�e�c�k�(�s�e�l�f�,� �(�P�y�T�y�p�e�O�b�j�e�c�t� �*�)�&�P�y�W�i�n�d�o�w�s�C�o�n�s�o�l�e�I�O�_�T�y�p�e�)�,� �f�i�l�e� �D�:�\�a�\�c�p�y�t�h�o�n�\�c�p�y�t�h�o�n�\�M�o�d�u�l�e�s�\�_�i�o�\�w�i�n�c�o�n�s�o�l�e�i�o�.�c�,� �l�i�n�e� �2�6�8� �Fatal Python error: Aborted There are still some test failures. Tell me if you need my help to debug that next week. |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
Draft! I don't have a Windows dev environment set up, so I rely on the CI for these changes. |
Sorry, something went wrong.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
Copy link
Copy Markdown
|
🤖 New build scheduled with the buildbot fleet by @erlend-aasland for commit 7c9065f 🤖 If you want to schedule another build, you need to add the 🔨 test-with-refleak-buildbots label again. |
Sorry, something went wrong.
Copy link
Copy Markdown
|
🤖 New build scheduled with the buildbot fleet by @erlend-aasland for commit cf81d43 🤖 If you want to schedule another build, you need to add the 🔨 test-with-refleak-buildbots label again. |
Sorry, something went wrong.
kumaraditya303
approved these changes
May 7, 2023
Copy link
Copy Markdown
Contributor
Author
|
Why isn't the Windows ref leaks bots part of the refleak portion of the fleet? |
Sorry, something went wrong.
vstinner
reviewed
May 9, 2023
vstinner
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Review after merge: LGTM, but the #ifdef around assert() is wrong IMO.
Sorry, something went wrong.
Comment thread
Modules/_io/winconsoleio.c
erlend-aasland
added a commit
to erlend-aasland/cpython
that referenced
this pull request
May 10, 2023
erlend-aasland
added a commit
that referenced
this pull request
May 10, 2023
carljm
added a commit
to carljm/cpython
that referenced
this pull request
May 10, 2023
* main: pythonGH-102181: Improve specialization stats for SEND (pythonGH-102182) pythongh-103000: Optimise `dataclasses.asdict` for the common case (python#104364) pythongh-103538: Remove unused TK_AQUA code (pythonGH-103539) pythonGH-87695: Fix OSError from `pathlib.Path.glob()` (pythonGH-104292) pythongh-104263: Rely on Py_NAN and introduce Py_INFINITY (pythonGH-104202) pythongh-104010: Separate and improve docs for `typing.get_origin` and `typing.get_args` (python#104013) pythongh-101819: Adapt _io._BufferedIOBase_Type methods to Argument Clinic (python#104355) pythongh-103960: Dark mode: invert image brightness (python#103983) pythongh-104252: Immortalize Py_EMPTY_KEYS (pythongh-104253) pythongh-101819: Clean up _io windows console io after pythongh-104197 (python#104354) pythongh-101819: Harden _io init (python#104352) pythongh-103247: clear the module cache in a test in test_importlib/extensions/test_loader.py (pythonGH-104226) pythongh-103848: Adds checks to ensure that bracketed hosts found by urlsplit are of IPv6 or IPvFuture format (python#103849) pythongh-74895: adjust tests to work on Solaris (python#104326) pythongh-101819: Refactor _io in preparation for module isolation (python#104334) pythongh-90953: Don't use deprecated AST nodes in clinic.py (python#104322) pythongh-102327: Extend docs for "url" and "headers" parameters to HTTPConnection.request() pythongh-104328: Fix typo in ``typing.Generic`` multiple inheritance error message (python#104335)
carljm
added a commit
to carljm/cpython
that referenced
this pull request
May 11, 2023
* main: (27 commits) pythongh-87849: fix SEND specialization family definition (pythonGH-104268) pythongh-101819: Adapt _io.IOBase.seek and _io.IOBase.truncate to Argument Clinic (python#104384) pythongh-101819: Adapt _io._Buffered* methods to Argument Clinic (python#104367) pythongh-101819: Refactor `_io` futher in preparation for module isolation (python#104369) pythongh-101819: Adapt _io.TextIOBase methods to Argument Clinic (python#104383) pythongh-101117: Improve accuracy of sqlite3.Cursor.rowcount docs (python#104287) pythonGH-92184: Convert os.altsep to '/' in filenames when creating ZipInfo objects (python#92185) pythongh-104357: fix inlined comprehensions that close over iteration var (python#104368) pythonGH-90208: Suppress OSError exceptions from `pathlib.Path.glob()` (pythonGH-104141) pythonGH-102181: Improve specialization stats for SEND (pythonGH-102182) pythongh-103000: Optimise `dataclasses.asdict` for the common case (python#104364) pythongh-103538: Remove unused TK_AQUA code (pythonGH-103539) pythonGH-87695: Fix OSError from `pathlib.Path.glob()` (pythonGH-104292) pythongh-104263: Rely on Py_NAN and introduce Py_INFINITY (pythonGH-104202) pythongh-104010: Separate and improve docs for `typing.get_origin` and `typing.get_args` (python#104013) pythongh-101819: Adapt _io._BufferedIOBase_Type methods to Argument Clinic (python#104355) pythongh-103960: Dark mode: invert image brightness (python#103983) pythongh-104252: Immortalize Py_EMPTY_KEYS (pythongh-104253) pythongh-101819: Clean up _io windows console io after pythongh-104197 (python#104354) pythongh-101819: Harden _io init (python#104352) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.