gh-90953: Emit deprecation warnings for ast features deprecated in Python 3.8 - #104199
gh-90953: Emit deprecation warnings for ast features deprecated in Python 3.8#104199AlexWaygood merged 29 commits into
Conversation
Sorry, something went wrong.
Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>
Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>
…good/cpython into ast-deprecation-warnings
| self.assertIsInstance(n, N) | ||
| self.assertIsinstance(n, ast.Num) | ||
| self.assertNotIsInstance(n, N2) | ||
| self.assertNotIsInstance(ast.Num(42), N) |
There was a problem hiding this comment.
Nice :)
By the way, https://github.com/isidentical/teyit / https://pypi.org/project/teyit/ is a nice tool that can upgrade some of these automatically.
Sorry, something went wrong.
barneygale
left a comment
There was a problem hiding this comment.
Is it necessary to emit deprecation warnings when the names are accessed on the ast module? Would it not be sufficient to emit warnings when these classes are instantiated (+ isinstance etc)?
Sorry, something went wrong.
I guess I lean towards keeping them just to ensure maximum visibility. There are edge cases where you might not be "using" the class or calling isinstance() on it, but you do reference it (if type(blah) is ast.Num, etc.). But you are right that we could probably simplify the code somewhat if we only warned on instantiation and isinstance() checks. @hugovk, do you have any thoughts on this? |
Sorry, something went wrong.
|
If there are two common ways of accessing something, I'd also lean towards more visibility for both. Speaking from a position of having dealt with the fallout of removing something without a DeprecationWarning first, just mentioning in docs :) |
Sorry, something went wrong.
|
Thanks very much, both of you! |
Sorry, something went wrong.
…ed in Python 3.8 (python#104199) `ast.Num`, `ast.Str`, `ast.Bytes`, `ast.Ellipsis` and `ast.NameConstant` now all emit deprecation warnings on import, access, instantation or `isinstance()` checks. Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
|
@AlexWaygood Is it time to make the PR to remove them now? |
Sorry, something went wrong.
yes |
Sorry, something went wrong.
See #119563 |
Sorry, something went wrong.
This is a continuation of @serhiy-storchaka's PR #31432, but removes the deprecation warnings for ast.ExtSlice and ast.Index, which were only deprecated in Python 3.9 (rationale for excluding them: #31432 (comment)).
📚 Documentation preview 📚: https://cpython-previews--104199.org.readthedocs.build/