gh-99113: Add Py_MOD_PER_INTERPRETER_GIL_SUPPORTED - #104205
Merged
ericsnowcurrently merged 3 commits intoMay 5, 2023
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
ericsnowcurrently
marked this pull request as ready for review
May 5, 2023 16:57
ericsnowcurrently
requested review from
a team,
1st1,
AlexWaygood,
Fidget-Spinner,
JelleZijlstra,
abalkin,
asvetlov,
berkerpeksag,
brettcannon,
corona10,
encukou,
erlend-aasland,
gpshead,
gvanrossum,
isidentical,
kumaraditya303,
ncoghlan,
pablogsal,
pganssle,
rhettinger,
tiran,
warsaw and
willingc
as code owners
May 5, 2023 16:57
ericsnowcurrently
removed request for
a team,
JelleZijlstra,
gvanrossum and
rhettinger
May 5, 2023 16:57
Copy link
Copy Markdown
Contributor
|
FYI, there are now two NEWS entries in this PR. |
Sorry, something went wrong.
ericsnowcurrently
force-pushed
the
per-interpreter-gil-extension-check
branch
2 times, most recently
from
532330d to
a1b027a
Compare
May 5, 2023 20:21
ericsnowcurrently
enabled auto-merge (squash)
May 5, 2023 20:27
erlend-aasland
approved these changes
May 5, 2023
ericsnowcurrently
disabled auto-merge
May 5, 2023 20:33
Copy link
Copy Markdown
Member
Author
|
Sorry for any noise here. I realized it would be better to add Py_MOD_PER_INTERPRETER_GIL_SUPPORTED now, while we wait for gh-104204. |
Sorry, something went wrong.
ericsnowcurrently
enabled auto-merge (squash)
May 5, 2023 20:34
Comment thread
Modules/_curses_panel.c
25 tasks
Comment thread
Modules/faulthandler.c
carljm
added a commit
to carljm/cpython
that referenced
this pull request
May 5, 2023
* main: pythongh-99113: Add PyInterpreterConfig.own_gil (pythongh-104204) pythongh-104146: Remove unused var 'parser_body_declarations' from clinic.py (python#104214) pythongh-99113: Add Py_MOD_PER_INTERPRETER_GIL_SUPPORTED (pythongh-104205) pythongh-104108: Add the Py_mod_multiple_interpreters Module Def Slot (pythongh-104148) pythongh-99113: Share the GIL via PyInterpreterState.ceval.gil (pythongh-104203) pythonGH-100479: Add `pathlib.PurePath.with_segments()` (pythonGH-103975) pythongh-69152: Add _proxy_response_headers attribute to HTTPConnection (python#26152) pythongh-103533: Use PEP 669 APIs for cprofile (pythonGH-103534) pythonGH-96803: Add three C-API functions to make _PyInterpreterFrame less opaque for users of PEP 523. (pythonGH-96849)
ericsnowcurrently
added a commit
that referenced
this pull request
May 6, 2023
jbower-fb
pushed a commit
to jbower-fb/cpython
that referenced
this pull request
May 8, 2023
…4205) Here we are doing no more than adding the value for Py_mod_multiple_interpreters and using it for stdlib modules. We will start checking for it in pythongh-104206 (once PyInterpreterState.ceval.own_gil is added in pythongh-104204).
jbower-fb
pushed a commit
to jbower-fb/cpython
that referenced
this pull request
May 8, 2023
…ythongh-104206) Py_MOD_PER_INTERPRETER_GIL_SUPPORTED is a new supported value for Py_mod_multiple_interpreters, added in pythongh-104205.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Here we are doing no more than adding the value for Py_mod_multiple_interpreters. We will start checking for it in gh-104206 (once PyInterpreterState.ceval.own_gil is added in gh-104204).