gh-97696: Use PyObject_CallMethodNoArgs and inline is_loop_running check - #104255
Merged
kumaraditya303 merged 1 commit intoMay 7, 2023
Merged
gh-97696: Use PyObject_CallMethodNoArgs and inline is_loop_running check#104255kumaraditya303 merged 1 commit into
kumaraditya303 merged 1 commit into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
…ing check based on feedback from python#102853 (review)
itamaro
requested review from
1st1,
asvetlov,
gvanrossum,
kumaraditya303 and
willingc
as code owners
May 7, 2023 00:36
gvanrossum
approved these changes
May 7, 2023
gvanrossum
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
LGTM, but this was @kumaraditya303's idea so he can review and merge it.
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
thanks! can you trigger refleak buildbots in the meantime so @kumaraditya303 can merge with confidence when he gets to it? :) |
Sorry, something went wrong.
Copy link
Copy Markdown
|
🤖 New build scheduled with the buildbot fleet by @JelleZijlstra for commit 20048db 🤖 If you want to schedule another build, you need to add the 🔨 test-with-refleak-buildbots label again. |
Sorry, something went wrong.
kumaraditya303
approved these changes
May 7, 2023
jbower-fb
pushed a commit
to jbower-fb/cpython
that referenced
this pull request
May 8, 2023
…nning check in `_asyncio` (python#104255)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
based on feedback from #102853 (review)