gh-101819: Port _io.PyBytesIOBuffer_Type to heap type - #104264
Merged
erlend-aasland merged 2 commits intoMay 7, 2023
Merged
Conversation
Copy link
Copy Markdown
|
🤖 New build scheduled with the buildbot fleet by @erlend-aasland for commit 7e628db 🤖 If you want to schedule another build, you need to add the 🔨 test-with-refleak-buildbots label again. |
Sorry, something went wrong.
erlend-aasland
commented
May 7, 2023
Comment thread
Modules/_io/_iomodule.c
Outdated
|
|
||
| // PyRawIOBase_Type(PyIOBase_Type) subclasses | ||
| state->PyBytesIOBuffer_Type = (PyTypeObject *)Py_NewRef(&_PyBytesIOBuffer_Type); | ||
| ADD_TYPE(m, state->PyBytesIOBuffer_Type, &bytesiobuf_spec, NULL); // XXX: should be subclass of PyRawIOBase_Type? |
Copy link
Copy Markdown
Contributor
Author
There was a problem hiding this comment.
FYI, I'll remove the XXX comment and move this line up to 753 when the refleak CI comes out green.
Sorry, something went wrong.
kumaraditya303
approved these changes
May 7, 2023
Copy link
Copy Markdown
Contributor
Author
|
CI including refleak bots are all green. I'll resolve my remark from #104264 (comment) and enable automerge. |
Sorry, something went wrong.
erlend-aasland
enabled auto-merge (squash)
May 7, 2023 13:32
jbower-fb
pushed a commit
to jbower-fb/cpython
that referenced
this pull request
May 8, 2023
vstinner
reviewed
May 9, 2023
vstinner
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Review after the merge: LGTM.
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.