FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-104360: remove reference to removed module-level wrap_socket by graingert · Pull Request #104361 · python/cpython · GitHub

  1. python
  2. cpython

Repository navigation

gh-104360: remove reference to removed module-level wrap_socket - #104361

Merged
encukou merged 3 commits into
python:mainfrom
graingert:remove-wrap-socket-ref
Jan 24, 2024
ConversationCommits (3)ChecksFiles changed
Merged

gh-104360: remove reference to removed module-level wrap_socket#104361
encukou merged 3 commits into
python:mainfrom
graingert:remove-wrap-socket-ref

Conversation

graingert commented May 10, 2023 •
edited by github-actions Bot
Loading

Copy link
Copy Markdown
Contributor

bedevere-bot mentioned this pull request May 10, 2023
Closed
bedevere-bot added docs Documentation in the Doc dir skip news labels May 10, 2023
graingert commented May 10, 2023
View reviewed changes
Comment thread Doc/library/ssl.rst Outdated
graingert marked this pull request as ready for review May 10, 2023 14:57
eamanu reviewed May 10, 2023
View reviewed changes
Comment thread Doc/library/ssl.rst
:exc:`SSLWantReadError` if it needs more data than the incoming BIO has
available.

- There is no module-level ``wrap_bio()`` call like there is for

eamanu May 10, 2023

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

ssl.wrap_context() is removed, but ssl.SSLContext.wrap_socket does not.

graingert May 10, 2023

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

@eamanu right but there is no module-level wrap_socket so this section doesn't make sense anymore

graingert requested a review from eamanu June 2, 2023 09:57
graingert requested a review from tiran November 1, 2023 18:49
AA-Turner approved these changes Jan 12, 2024
View reviewed changes

AA-Turner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

The substantive documentation was removed in #99023.

A

AA-Turner added needs backport to 3.11 only security fixes needs backport to 3.12 only security fixes labels Jan 12, 2024
AA-Turner requested a review from encukou January 12, 2024 23:03
encukou merged commit 127a497 into python:main Jan 24, 2024

miss-islington-app Bot commented Jan 24, 2024

Copy link
Copy Markdown

Thanks @graingert for the PR, and @encukou for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jan 24, 2024
pythongh-104360: remove reference to removed module-level wrap_socket (…
235d7a4 
…pythonGH-104361)

* remove reference to removed module-level wrap_socket
* drive by typo fix
(cherry picked from commit 127a497)

Co-authored-by: Thomas Grainger <tagrain@gmail.com>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jan 24, 2024
pythongh-104360: remove reference to removed module-level wrap_socket (…
4df116f 
…pythonGH-104361)

* remove reference to removed module-level wrap_socket
* drive by typo fix
(cherry picked from commit 127a497)

Co-authored-by: Thomas Grainger <tagrain@gmail.com>

bedevere-app Bot commented Jan 24, 2024

Copy link
Copy Markdown

GH-114528 is a backport of this pull request to the 3.12 branch.

bedevere-app Bot removed the needs backport to 3.12 only security fixes label Jan 24, 2024

bedevere-app Bot commented Jan 24, 2024

Copy link
Copy Markdown

GH-114529 is a backport of this pull request to the 3.11 branch.

bedevere-app Bot removed the needs backport to 3.11 only security fixes label Jan 24, 2024
encukou pushed a commit that referenced this pull request Jan 24, 2024
[3.12] gh-104360: remove reference to removed module-level wrap_socket (
26f8a30 
GH-104361) (GH-114528)

* remove reference to removed module-level wrap_socket
* drive by typo fix
(cherry picked from commit 127a497)

Co-authored-by: Thomas Grainger <tagrain@gmail.com>
aisk pushed a commit to aisk/cpython that referenced this pull request Feb 11, 2024
pythongh-104360: remove reference to removed module-level wrap_socket (…
efdd16a 
…pythonGH-104361)

* remove reference to removed module-level wrap_socket
* drive by typo fix
Glyphack pushed a commit to Glyphack/cpython that referenced this pull request Sep 2, 2024
pythongh-104360: remove reference to removed module-level wrap_socket (…
b6625a7 
…pythonGH-104361)

* remove reference to removed module-level wrap_socket
* drive by typo fix
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

AA-Turner AA-Turner approved these changes
tiran Awaiting requested review from tiran
encukou Awaiting requested review from encukou
+1 more reviewer
eamanu eamanu approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

docs Documentation in the Doc dir skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

Back | FazBrowse Home | New Git URL