FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-101819: Explicitly disallow pickle protocols 0 and 1 in _io by erlend-aasland · Pull Request #104370 · python/cpython · GitHub

/ cpython Public

gh-101819: Explicitly disallow pickle protocols 0 and 1 in _io - #104370

Closed
erlend-aasland wants to merge 4 commits into
python:mainfrom
erlend-aasland:isolate-io/pickle
ConversationCommits (4)ChecksFiles changed
Closed

gh-101819: Explicitly disallow pickle protocols 0 and 1 in _io#104370
erlend-aasland wants to merge 4 commits into
python:mainfrom
erlend-aasland:isolate-io/pickle

Conversation

erlend-aasland commented May 10, 2023 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Contributor

This is part of the preparations for isolating the _io module.

pythongh-101819: Explicitly disallow pickle protocols 0 and 1 in _io
e11489e 
This is part of the preparations for isolating the _io module.
bedevere-bot mentioned this pull request May 10, 2023
Closed

erlend-aasland commented May 10, 2023 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

See #84258 (comment) and #85224 (comment), for more info

vstinner commented May 11, 2023

Copy link
Copy Markdown
Member

See #84258 (comment) and #85224 (comment), for more info

I'm not confortable to have to dig deep into the bug tracker to get reliable information about object serialization. Can it be written in the Python documentation instead?

Since these comments, I recall that @serhiy-storchaka made generic changes on base object type so it's no longer needed, no?

object.__reduce__() has now a default implementation which returns the string "NotImplemented". Is this change still needed?

erlend-aasland commented May 11, 2023

Copy link
Copy Markdown
Contributor Author

object.__reduce__() has now a default implementation which returns the string "NotImplemented". Is this change still needed?

Hm, perhaps we only need to change the _io tests.

erlend-aasland commented May 11, 2023

Copy link
Copy Markdown
Contributor Author

I believe you are right, @vstinner; there is no need for this.

erlend-aasland marked this pull request as draft May 11, 2023 20:07
erlend-aasland deleted the isolate-io/pickle branch May 12, 2023 08:28
erlend-aasland mentioned this pull request May 12, 2023
Merged
yuxuanzhuang mentioned this pull request Sep 22, 2023
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

kumaraditya303 Awaiting requested review from kumaraditya303
vstinner Awaiting requested review from vstinner

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL