FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

bpo-35202: Remove unused imports in idle lib package by srinivasreddy · Pull Request #10438 · python/cpython · GitHub

  1. python
  2. cpython

Repository navigation

bpo-35202: Remove unused imports in idle lib package - #10438

Merged
terryjreedy merged 4 commits into
python:masterfrom
srinivasreddy:rm_dead_imports_idle
Nov 10, 2018
ConversationCommits (4)ChecksFiles changed
Merged

bpo-35202: Remove unused imports in idle lib package#10438
terryjreedy merged 4 commits into
python:masterfrom
srinivasreddy:rm_dead_imports_idle

Conversation

srinivasreddy commented Nov 9, 2018 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Contributor

srinivasreddy changed the title Remove unused imports in idlelib package bpo-35202: Remove unused imports in idlelib package Nov 9, 2018
srinivasreddy changed the title bpo-35202: Remove unused imports in idlelib package bpo-35202: Remove unused imports in Lib directory Nov 9, 2018

terryjreedy commented Nov 10, 2018

Copy link
Copy Markdown
Member

Please revert this PR to the original title and to only change idlelib. These changes can and should be backported to 3.7 and 3.6. If you can, add a generic blurb using the current 'lib' title. Then I will merge.

Put other changes in a separate PR for the same issue, as those likely will not be backported. If there is a blurb with this PR, another PR will not need a blurb as there should be only 1 blurb per issue.

gvanrossum removed their request for review November 10, 2018 01:27
srinivasreddy changed the title bpo-35202: Remove unused imports in Lib directory bpo-35202: Remove unused imports in idle lib package Nov 10, 2018
srinivasreddy mentioned this pull request Nov 10, 2018
Merged
terryjreedy self-assigned this Nov 10, 2018
terryjreedy merged commit 43a74ab into python:master Nov 10, 2018

miss-islington commented Nov 10, 2018

Copy link
Copy Markdown
Contributor

Thanks @srinivasreddy for the PR, and @terryjreedy for merging it 🌮🎉.. I'm working now to backport this PR to: 3.6, 3.7.
🐍🍒⛏🤖

bedevere-bot commented Nov 10, 2018

Copy link
Copy Markdown

GH-10447 is a backport of this pull request to the 3.7 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Nov 10, 2018
bpo-35202: Remove unused imports in idlelib (pythonGH-10438)
6ee4cdb 
(cherry picked from commit 43a74ab)

Co-authored-by: Srinivas  Thatiparthy (శ్రీనివాస్  తాటిపర్తి) <thatiparthysreenivas@gmail.com>

bedevere-bot commented Nov 10, 2018

Copy link
Copy Markdown

GH-10448 is a backport of this pull request to the 3.6 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Nov 10, 2018
bpo-35202: Remove unused imports in idlelib (pythonGH-10438)
f546add 
(cherry picked from commit 43a74ab)

Co-authored-by: Srinivas  Thatiparthy (శ్రీనివాస్  తాటిపర్తి) <thatiparthysreenivas@gmail.com>
miss-islington added a commit that referenced this pull request Nov 10, 2018
bpo-35202: Remove unused imports in idlelib (GH-10438)
2847cca 
(cherry picked from commit 43a74ab)

Co-authored-by: Srinivas  Thatiparthy (శ్రీనివాస్  తాటిపర్తి) <thatiparthysreenivas@gmail.com>
miss-islington added a commit that referenced this pull request Nov 10, 2018
bpo-35202: Remove unused imports in idlelib (GH-10438)
2903b0f 
(cherry picked from commit 43a74ab)

Co-authored-by: Srinivas  Thatiparthy (శ్రీనివాస్  తాటిపర్తి) <thatiparthysreenivas@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

terryjreedy Awaiting requested review from terryjreedy
ilevkivskyi Awaiting requested review from ilevkivskyi

Assignees

terryjreedy

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

Back | FazBrowse Home | New Git URL