FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-104341: Ensure tstate Holding GIL is Always Current by ericsnowcurrently · Pull Request #104436 · python/cpython · GitHub

/ cpython Public
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension .c  (4) .h  (1) All 2 file types selected
Viewed files
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Unified
Split
Hide whitespace
Diff view
Unified
Split
Hide whitespace
1 change: 1 addition & 0 deletions Include/internal/pycore_ceval.h
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Original file line number Diff line number Diff line change
Expand Up @@ -101,6 +101,7 @@ extern void _PyEval_FiniGIL(PyInterpreterState *interp);

extern void _PyEval_AcquireLock(PyThreadState *tstate);
extern void _PyEval_ReleaseLock(PyThreadState *tstate);
extern int _PyEval_HoldsLock(PyThreadState *tstate);
extern PyThreadState * _PyThreadState_SwapNoGIL(PyThreadState *);

extern void _PyEval_DeactivateOpCache(void);
Expand Down
1 change: 1 addition & 0 deletions Modules/_threadmodule.c
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
/* Interface to Sjoerd's portable C thread library */

#include "Python.h"
#include "pycore_ceval.h" // _PyEval_HoldsLock()
#include "pycore_interp.h" // _PyInterpreterState.threads.count
#include "pycore_moduleobject.h" // _PyModule_GetState()
#include "pycore_pylifecycle.h"
Expand Down
41 changes: 28 additions & 13 deletions Python/ceval_gil.c
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Original file line number Diff line number Diff line change
Expand Up @@ -282,7 +282,10 @@ drop_gil(struct _ceval_state *ceval, PyThreadState *tstate)
if (!_Py_atomic_load_relaxed(&gil->locked)) {
Py_FatalError("drop_gil: GIL is not locked");
}
assert(_Py_tss_tstate == tstate);
assert(((PyThreadState *)_Py_atomic_load_relaxed(&gil->last_holder)) == tstate);

// XXX Does this still hold?
/* tstate is allowed to be NULL (early interpreter init) */
if (tstate != NULL) {
/* Sub-interpreter support: threads might have been switched
Expand Down Expand Up @@ -348,6 +351,7 @@ take_gil(PyThreadState *tstate)

assert(tstate != NULL);

assert(_Py_tss_tstate == tstate);
if (tstate_must_exit(tstate)) {
/* bpo-39877: If Py_Finalize() has been called and tstate is not the
thread which called Py_Finalize(), exit immediately the thread.
Expand Down Expand Up @@ -629,29 +633,37 @@ _PyEval_ReleaseLock(PyThreadState *tstate)
drop_gil(ceval, tstate);
}

int
_PyEval_HoldsLock(PyThreadState *tstate)
{
_Py_EnsureTstateNotNULL(tstate);
return current_thread_holds_gil(tstate->interp->ceval.gil, tstate);
}

void
PyEval_AcquireThread(PyThreadState *tstate)
{
_Py_EnsureTstateNotNULL(tstate);

take_gil(tstate);

if (_PyThreadState_SwapNoGIL(tstate) != NULL) {
Py_FatalError("non-NULL old thread state");
}

take_gil(tstate);
}

void
PyEval_ReleaseThread(PyThreadState *tstate)
{
assert(is_tstate_valid(tstate));

struct _ceval_state *ceval = &tstate->interp->ceval;
drop_gil(ceval, tstate);

PyThreadState *new_tstate = _PyThreadState_SwapNoGIL(NULL);
if (new_tstate != tstate) {
Py_FatalError("wrong thread state");
}
struct _ceval_state *ceval = &tstate->interp->ceval;
drop_gil(ceval, tstate);
}

#ifdef HAVE_FORK
Expand Down Expand Up @@ -694,12 +706,15 @@ _PyEval_SignalAsyncExc(PyInterpreterState *interp)
PyThreadState *
PyEval_SaveThread(void)
{
PyThreadState *current_tstate = _PyThreadState_GET();
_Py_EnsureTstateNotNULL(current_tstate);
struct _ceval_state *ceval = &current_tstate->interp->ceval;
assert(gil_created(ceval->gil));
drop_gil(ceval, current_tstate);

PyThreadState *tstate = _PyThreadState_SwapNoGIL(NULL);
_Py_EnsureTstateNotNULL(tstate);
assert(tstate == current_tstate);

struct _ceval_state *ceval = &tstate->interp->ceval;
assert(gil_created(ceval->gil));
drop_gil(ceval, tstate);
return tstate;
}

Expand All @@ -708,9 +723,9 @@ PyEval_RestoreThread(PyThreadState *tstate)
{
_Py_EnsureTstateNotNULL(tstate);

take_gil(tstate);

_PyThreadState_SwapNoGIL(tstate);

take_gil(tstate);
}


Expand Down Expand Up @@ -1006,18 +1021,18 @@ _Py_HandlePending(PyThreadState *tstate)
/* GIL drop request */
if (_Py_atomic_load_relaxed_int32(&interp_ceval_state->gil_drop_request)) {
/* Give another thread a chance */
assert(tstate == _PyThreadState_GET());
drop_gil(interp_ceval_state, tstate);
if (_PyThreadState_SwapNoGIL(NULL) != tstate) {
Py_FatalError("tstate mix-up");
}
drop_gil(interp_ceval_state, tstate);

/* Other threads may run now */

take_gil(tstate);

if (_PyThreadState_SwapNoGIL(tstate) != NULL) {
Py_FatalError("orphan tstate");
}
take_gil(tstate);
}

/* Check for asynchronous exception. */
Expand Down
10 changes: 8 additions & 2 deletions Python/pylifecycle.c
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Original file line number Diff line number Diff line change
Expand Up @@ -2027,8 +2027,16 @@ new_interpreter(PyThreadState **tstate_p, const PyInterpreterConfig *config)
}
_PyThreadState_Bind(tstate);

// We must release the GIL before swapping.
PyThreadState *current_tstate = _PyThreadState_GET();
if (current_tstate != NULL) {
// XXX Might new_interpreter() have been called without the GIL held?
_PyEval_ReleaseLock(current_tstate);
}

// XXX For now we do this before the GIL is created.
PyThreadState *save_tstate = _PyThreadState_SwapNoGIL(tstate);
assert(save_tstate == current_tstate);
int has_gil = 0;

/* From this point until the init_interp_create_gil() call,
Expand All @@ -2039,8 +2047,6 @@ new_interpreter(PyThreadState **tstate_p, const PyInterpreterConfig *config)
/* Copy the current interpreter config into the new interpreter */
const PyConfig *src_config;
if (save_tstate != NULL) {
// XXX Might new_interpreter() have been called without the GIL held?
_PyEval_ReleaseLock(save_tstate);
src_config = _PyInterpreterState_GetConfig(save_tstate->interp);
}
else
Expand Down
4 changes: 3 additions & 1 deletion Python/pystate.c
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Original file line number Diff line number Diff line change
Expand Up @@ -1564,8 +1564,10 @@ _PyThreadState_DeleteCurrent(PyThreadState *tstate)
{
_Py_EnsureTstateNotNULL(tstate);
tstate_delete_common(tstate);
current_fast_clear(tstate->interp->runtime);
assert(_Py_tss_tstate == tstate);
assert(_PyEval_HoldsLock(tstate));
_PyEval_ReleaseLock(tstate);
current_fast_clear(tstate->interp->runtime);
free_threadstate(tstate);
}

Expand Down

Back | FazBrowse Home | New Git URL