| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
Sorry, something went wrong.
There was a problem hiding this comment.
The CI on this PR is currently failing to start due to invalid workflow syntax:
https://github.com/python/cpython/actions/runs/4977097067
The workflow is not valid. .github/workflows/build.yml (Line: 378, Col: 11): A sequence was not expected
Sorry, something went wrong.
|
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request. |
Sorry, something went wrong.
|
I have made the requested changes; please review again. |
Sorry, something went wrong.
|
Thanks for making the requested changes! @AlexWaygood: please review the changes made to this pull request. |
Sorry, something went wrong.
| key: hypothesis-database-${{ github.head_ref || github.run_id }} | ||
| restore-keys: | ||
| restore-keys: | | ||
| - hypothesis-database- |
There was a problem hiding this comment.
@Zac-HD did you mean to keep that leading hyphen?
Sorry, something went wrong.
There was a problem hiding this comment.
This makes it look up the '- hypothesis-database-' prefix, and I'm pretty sure you wanted 'hypothesis-database-':
Cache not found for input keys: hypothesis-database-9927179210, - hypothesis-database-(https://github.com/python/cpython/actions/runs/9927179210/job/27421821417#step:21:24)
Sorry, something went wrong.
Sorry, something went wrong.
| Back | FazBrowse Home | New Git URL |
Per #22863 (comment), this PR configures Hypothesis to ignore unexpectedly slow tests. Relative to the default of failing, this reduces flakiness due to variable performance of CI machines.
The second commit adds caching to the CI test run, so that if a CI run finds a rare but real failure that input will be replayed in future CI runs (at least until the cache expires, or the test passes and Hypothesis discards the now-passing input). This doesn't come up often, but if it does will convert flaky tests into reliable failures.
Third, we can upload the database as an "artifact" from CI and configure local runs to use that as a pull-through cache - meaning that "reproducing a failure from CI" is just "run the tests locally". No impact on flakiness but it's a rather nice workflow! 1
cc @pganssle for review / checking that it works on your machine
Footnotes
Unfortunately the 'dump a patch with explicit examples' workflow relies on libcst and our pytest plugin - if this would be particularly interesting we can talk about making it work with unittest and perhaps even ast. ↩