FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-104539: Fix indentation error in logging.config.rst by jnoordsij · Pull Request #104540 · python/cpython · GitHub

/ cpython Public

gh-104539: Fix indentation error in logging.config.rst - #104540

Closed
jnoordsij wants to merge 1 commit into
python:3.11from
jnoordsij:patch-1
ConversationCommits (1)ChecksFiles changed
Closed

gh-104539: Fix indentation error in logging.config.rst#104540
jnoordsij wants to merge 1 commit into
python:3.11from
jnoordsij:patch-1

Conversation

jnoordsij commented May 16, 2023 •
edited by github-actions Bot
Loading

Copy link
Copy Markdown
Contributor

I think this should solve #104539, but I'm not entirely sure.

📚 Documentation preview 📚: https://cpython-previews--104540.org.readthedocs.build/

jnoordsij requested a review from vsajip as a code owner May 16, 2023 10:58

ghost commented May 16, 2023 •
edited by ghost
Loading

Copy link
Copy Markdown

All commit authors signed the Contributor License Agreement.

bedevere-bot mentioned this pull request May 16, 2023
Closed
bedevere-bot added docs Documentation in the Doc dir skip news labels May 16, 2023

hugovk commented May 16, 2023

Copy link
Copy Markdown
Member

Please could you make this PR against the main branch instead of 3.11? We can then backport it to 3.11 from there.

Don't change the base branch at the top of this PR, because it rarely works as planned and ends up pinging lots of people through the CODEOWNERS file. Instead, close this PR and re-open a new one.

Thank you!

hugovk removed the request for review from vsajip May 16, 2023 11:10

vsajip commented May 16, 2023

Copy link
Copy Markdown
Member

I'll close this, and wait for the patch against the main branch.

vsajip closed this May 16, 2023

jnoordsij commented May 16, 2023

Copy link
Copy Markdown
Contributor Author

Please could you make this PR against the main branch instead of 3.11? We can then backport it to 3.11 from there.

Don't change the base branch at the top of this PR, because it rarely works as planned and ends up pinging lots of people through the CODEOWNERS file. Instead, close this PR and re-open a new one.

Thank you!

Ah that makes sense! Will open a new PR soon.

jnoordsij deleted the patch-1 branch May 16, 2023 11:49
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

awaiting review docs Documentation in the Doc dir skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

Back | FazBrowse Home | New Git URL