gh-104484: Add parameter @case_sensitive to pathlib.PurePath.match() function by thirumurugan-git · Pull Request #104565 · python/cpython · GitHub

Issue: Add case_sensitive argument to pathlib.PurePath.match() #104484

Most changes to Python require a NEWS entry.

Please add it using the blurb_it web app or the blurb command-line tool.

All commit authors signed the Contributor License Agreement.

Thanks for looking at this! The default value of case_sensitive should be None, which means "use platform-specific rules", i.e. case-sensitive on Posix and case-insensitive on Windows. See the implementation in glob().

Could you also add tests please? I think they'll show that your current patch doesn't enable case-sensitive matching on Windows, because the implementation is still working with the case-normalized parts.

Looking better! Could you also document the new argument in pathlib.rst? Thanks!

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

I have made the requested changes; please review again.

Thanks for making the requested changes!

@barneygale: please review the changes made to this pull request.

Nice! Pretty close now. Could you add an entry to the 3.12 "What's New" document? Apparently I forgot to add a paragraph there for the addition of case_sensitive to glob() and rglob() - if you could mention all three in a single bullet point I'd be much obliged!

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

And if you don't make the requested changes, you will be poked with soft cushions!

the requested changes; please review again.

Co-authored-by: Barney Gale <barney.gale@gmail.com>

…6KxL6.rst Co-authored-by: Barney Gale <barney.gale@gmail.com>

Co-authored-by: Barney Gale <barney.gale@gmail.com>

I have made the requested changes; please review again

Thanks for making the requested changes!

@barneygale: please review the changes made to this pull request.

One last thing, otherwise LGTM.

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

I have made the requested changes; please review again.

Thanks for making the requested changes!

@barneygale: please review the changes made to this pull request.

LGTM! Thanks for working on this.

* main: pythongh-74690: Don't set special protocol attributes on non-protocol subclasses of protocols (python#104622) pythongh-104623: Update Windows installer to use SQLite 3.42.0 (python#104625) pythongh-104050: Add more type annotations to Argument Clinic (python#104628) pythongh-104629: Don't skip test_clinic if _testclinic is missing (python#104630) pythongh-104549: Set __module__ on TypeAliasType (python#104550) pythongh-104050: Improve some typing around `default`s and sentinel values (python#104626) pythongh-104146: Remove unused vars from Argument Clinic (python#104627) pythongh-104615: don't make unsafe swaps in apply_static_swaps (python#104620) pythonGH-104484: Add case_sensitive argument to `pathlib.PurePath.match()` (pythonGH-104565) pythonGH-96803: Document and test new unstable internal frame API functions (pythonGH-104211) pythonGH-104580: Don't cache eval breaker in interpreter (pythonGH-104581)

Add parameter @case_sensitive to pathlib.PurePath.match() function

473eeaf

thirumurugan-git requested a review from barneygale as a code owner May 16, 2023 21:33

bedevere-bot added the awaiting review label May 16, 2023

bedevere-bot mentioned this pull request May 16, 2023

Add case_sensitive argument to pathlib.PurePath.match() #104484

Closed

thirumurugan-git added 2 commits May 17, 2023 03:15

Add NEWS entry

17e721f

Refactor case sensitive check

73907a6

Handle platform specific case sensitivity and add test cases

8c3f4a4

barneygale requested changes May 17, 2023

View reviewed changes

Comment thread Lib/test/test_pathlib.py Outdated

Comment thread Lib/test/test_pathlib.py Outdated

Comment thread Lib/pathlib.py Outdated

Comment thread Lib/pathlib.py Outdated

Comment thread Lib/pathlib.py Outdated

bedevere-bot added awaiting changes and removed awaiting review labels May 17, 2023

Code formatting

1e638fe

bedevere-bot added awaiting change review and removed awaiting changes labels May 17, 2023

bedevere-bot requested a review from barneygale May 17, 2023 21:31

barneygale requested changes May 17, 2023

View reviewed changes

Comment thread Doc/library/pathlib.rst Outdated

Comment thread Lib/pathlib.py Outdated

Comment thread Lib/pathlib.py Outdated

Comment thread Lib/pathlib.py Outdated

Comment thread Lib/test/test_pathlib.py

bedevere-bot added awaiting changes and removed awaiting change review labels May 17, 2023

Resolve threads

53e0bb8

barneygale requested changes May 18, 2023

View reviewed changes

Comment thread Doc/library/pathlib.rst Outdated

Comment thread Doc/whatsnew/3.12.rst Outdated

Comment thread Lib/pathlib.py Outdated

Comment thread Misc/NEWS.d/next/Library/2023-05-17-03-14-07.gh-issue-104484.y6KxL6.rst Outdated

thirumurugan-git and others added 3 commits May 18, 2023 07:44

Update Doc/whatsnew/3.12.rst

90ed5c6

Co-authored-by: Barney Gale <barney.gale@gmail.com>

Update Misc/NEWS.d/next/Library/2023-05-17-03-14-07.gh-issue-104484.y…

563172c

…6KxL6.rst Co-authored-by: Barney Gale <barney.gale@gmail.com>

Update Lib/pathlib.py

be06795

Co-authored-by: Barney Gale <barney.gale@gmail.com>

Update document

466abc2

bedevere-bot added awaiting change review and removed awaiting changes labels May 18, 2023

bedevere-bot requested a review from barneygale May 18, 2023 02:34

barneygale requested changes May 18, 2023

View reviewed changes

Comment thread Lib/pathlib.py

bedevere-bot added awaiting changes and removed awaiting change review labels May 18, 2023

Update pathlib.py

afee333

bedevere-bot added awaiting change review and removed awaiting changes labels May 18, 2023

bedevere-bot requested a review from barneygale May 18, 2023 07:47

barneygale approved these changes May 18, 2023

View reviewed changes

bedevere-bot added awaiting merge and removed awaiting change review labels May 18, 2023

barneygale merged commit dcdc90d into python:main May 18, 2023

bedevere-bot removed the awaiting merge label May 18, 2023

barneygale mentioned this pull request May 18, 2023

Path.rglob performance issues in deeply nested directories compared to glob.glob(recursive=True) #102613

Closed

gh-104484: Add parameter @case_sensitive to pathlib.PurePath.match() function by thirumurugan-git · Pull Request #104565 · python/cpython · GitHub

Uh oh!

Uh oh!

gh-104484: Add parameter @case_sensitive to pathlib.PurePath.match() function - #104565

gh-104484: Add parameter @case_sensitive to pathlib.PurePath.match() function#104565barneygale merged 11 commits intopython:mainpython/cpython:mainfrom thirumurugan-git:fix-issue-104484thirumurugan-git/cpython:fix-issue-104484Copy head branch name to clipboard

Conversation

thirumurugan-git commented May 16, 2023 • edited by bedevere-bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

bedevere-bot commented May 16, 2023

Uh oh!

ghost commented May 16, 2023 • edited by ghost Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

barneygale commented May 17, 2023

Uh oh!

barneygale left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

bedevere-bot commented May 17, 2023

Uh oh!

thirumurugan-git commented May 17, 2023

Uh oh!

bedevere-bot commented May 17, 2023

Uh oh!

barneygale left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

bedevere-bot commented May 17, 2023

Uh oh!

thirumurugan-git commented May 17, 2023

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

thirumurugan-git commented May 18, 2023

Uh oh!

bedevere-bot commented May 18, 2023

Uh oh!

barneygale left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

bedevere-bot commented May 18, 2023

Uh oh!

thirumurugan-git commented May 18, 2023

Uh oh!

bedevere-bot commented May 18, 2023

Uh oh!

barneygale left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

gh-104484: Add parameter @case_sensitive to pathlib.PurePath.match() function#104565
barneygale merged 11 commits into
python:mainfrom
thirumurugan-git:fix-issue-104484

thirumurugan-git commented May 16, 2023 •
edited by bedevere-bot
Loading

ghost commented May 16, 2023 •
edited by ghost
Loading