[3.11] typing: Add more tests for TypeVar (GH-104571) - #104577
Merged
JelleZijlstra merged 2 commits intoMay 17, 2023
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
During the PEP 695 implementation at one point I made TypeVar.__name__ return garbage, and all of test_typing passed. So I decided to add a few more tests. In the process I discovered a minor incompatibility from the C implementation of TypeVar: empty constraints were returned as None instead of an empty tuple.. (cherry picked from commit 2693194) Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>
JelleZijlstra
requested review from
AlexWaygood,
Fidget-Spinner and
gvanrossum
as code owners
May 17, 2023 13:12
JelleZijlstra
commented
May 17, 2023
Comment thread
Lib/test/test_typing.py
Outdated
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
During the PEP 695 implementation at one point I made TypeVar.name return garbage, and all of test_typing passed. So I decided to add a few more tests. (cherry picked from commit 2693194)