Repository navigation
[3.11] gh-104615: don't make unsafe swaps in apply_static_swaps (GH-104620). - #104636
Merged
carljm merged 1 commit intoMay 19, 2023
Merged
carljm merged 1 commit into
carljm merged 1 commit into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
…pythonGH-104620). (cherry picked from commit 0589c6a) Co-authored-by: Carl Meyer <carl@oddbird.net>
This was referenced May 19, 2023
Closed
carljm
marked this pull request as ready for review
May 19, 2023 00:55
Copy link
Copy Markdown
Member
Author
|
This required manual backport, but mostly just to eliminate all the stuff from the 3.12 PR that had to do with directly testing the optimizer, since the APIs for that don't exist in 3.11. Also there's no STORE_FAST_MAYBE_NULL. Still a pretty straightforward backport, but since it was manual I'll wait for review. |
Sorry, something went wrong.
brandtbucher
approved these changes
May 19, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(cherry picked from commit 0589c6a)