FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-104050: Argument clinic: Add annotations to the `LandMine` class by AlexWaygood · Pull Request #104648 · python/cpython · GitHub

/ cpython Public

gh-104050: Argument clinic: Add annotations to the LandMine class #104648

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
AlexWaygood wants to merge 2 commits into from
Conversation 4 Commits 2 Checks 0 Files changed
Closed

gh-104050: Argument clinic: Add annotations to the LandMine class #104648

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5b0a76b
gh-104050: Argument clinic: Add annotations to the `LandMine` class
AlexWaygood May 19, 2023
75abb87
comment
AlexWaygood May 19, 2023
File filter

Filter by extension

Filter by extension .py  (1) All 1 file type selected
Viewed files
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Unified
Split
Hide whitespace
Diff view
Unified
Split
Hide whitespace
23 changes: 15 additions & 8 deletions Tools/clinic/clinic.py
Show comments
View file
Open in desktop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@

from collections.abc import Callable
from types import FunctionType, NoneType
from typing import Any, Final, NamedTuple, NoReturn, Literal, overload
from typing import TYPE_CHECKING, Any, Final, NamedTuple, NoReturn, Literal, overload

# TODO:
#
Expand Down Expand Up @@ -2554,17 +2554,24 @@ def get_displayname(self, i):

class LandMine:
# try to access any
def __init__(self, message):
def __init__(self, message: str) -> None:
self.__message__ = message

def __repr__(self):
def __repr__(self) -> str:
return '<LandMine ' + repr(self.__message__) + ">"

def __getattribute__(self, name):
if name in ('__repr__', '__message__'):
return super().__getattribute__(name)
# raise RuntimeError(repr(name))
fail("Stepped on a land mine, trying to access attribute " + repr(name) + ":\n" + self.__message__)
# Type checkers wouldn't check attribute access on instances of this class properly
# if they saw it had a __getattribute__ method,
# so pretend to type checkers that the __getattribute__ method doesn't exist
if not TYPE_CHECKING:
def __getattribute__(self, name):
if name in ('__repr__', '__message__'):
return super().__getattribute__(name)
# raise RuntimeError(repr(name))
fail(
f"Stepped on a land mine, trying to access attribute "
f"{name!r}:\n{self.__message__}"
)


def add_c_converter(f, name=None):
Expand Down
Back | FazBrowse Home | New Git URL