gh-104341: Wait Completely at threading._shutdown() - #104672
Closed
ericsnowcurrently wants to merge 3 commits into
Closed
gh-104341: Wait Completely at threading._shutdown()#104672ericsnowcurrently wants to merge 3 commits into
ericsnowcurrently wants to merge 3 commits into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
|
I plan on revisiting this problem, to introduce a better long-term solution. However, that probably won't be in 3.12. |
Sorry, something went wrong.
ericsnowcurrently
force-pushed
the
fix-threading-module-shutdown-simpler
branch
from
6c79a9b to
8b42a15
Compare
May 23, 2023 21:00
ericsnowcurrently
marked this pull request as ready for review
May 23, 2023 21:01
Copy link
Copy Markdown
Member
|
Ae you still going with this, or has it been superseded? |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
|
It's superseded for the moment. I'm likely to revisit this for 3.13. |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(This should solve the semi-frequent buildbot failures we've been seeing.)
In Py_EndInterpreter() we almost immediately wait for all non-daemon Python threads to finish, by calling theading._shutdown(). However, with a per-interpreter GIL there's a race because threading._shutdown() doesn't wait long enough. This change fixes that by making sure _PyThreadState_DeleteCurrent() completely finishes before releasing the lock on which threading._shutdown() depends.
The gist of it is that we release that lock (and clean it up) later than we would normally be able to, by doing the cleanup in another thread via a "pending" call.
This isn't an ideal solution, but other approaches I tried involved more invasive changes, which I'd like to avoid this close to the beta 1 release.