FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-104050: Add basic type hints to Argument Clinic clinic class by erlend-aasland · Pull Request #104705 · python/cpython · GitHub

/ cpython Public

gh-104050: Add basic type hints to Argument Clinic clinic class - #104705

Merged
erlend-aasland merged 4 commits into
python:mainfrom
erlend-aasland:typed-clinic/clinic
May 21, 2023
ConversationCommits (4)ChecksFiles changed
Merged

gh-104050: Add basic type hints to Argument Clinic clinic class#104705
erlend-aasland merged 4 commits into
python:mainfrom
erlend-aasland:typed-clinic/clinic

Conversation

erlend-aasland commented May 20, 2023 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Contributor

bedevere-bot mentioned this pull request May 20, 2023
Closed
AlexWaygood reviewed May 21, 2023
View reviewed changes

AlexWaygood left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Some readability nits, and a few places where (if mypy doesn't complain about it), you could possibly make the annotations more precise (but those can all wait for now, if necessary)

Comment thread Tools/clinic/clinic.py Outdated
Comment thread Tools/clinic/clinic.py Outdated
Comment thread Tools/clinic/clinic.py
Comment thread Tools/clinic/clinic.py
Comment thread Tools/clinic/clinic.py Outdated
Comment thread Tools/clinic/clinic.py Outdated
AlexWaygood approved these changes May 21, 2023
View reviewed changes

AlexWaygood left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Thanks!

erlend-aasland commented May 21, 2023

Copy link
Copy Markdown
Contributor Author

Thanks!

Likewise! I'll look thrice before opening my next PRs, so you (hopefully) won't have to pick on basic stuff again :)

erlend-aasland enabled auto-merge (squash) May 21, 2023 20:28

AlexWaygood commented May 21, 2023

Copy link
Copy Markdown
Member

Thanks!

Likewise! I'll look thrice before opening my next PRs, so you (hopefully) won't have to pick on basic stuff again :)

Hey, typing is hard, no sweat! I still make mistakes all the time :)

erlend-aasland merged commit bf6dd8f into python:main May 21, 2023
erlend-aasland deleted the typed-clinic/clinic branch May 21, 2023 20:59
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

AlexWaygood AlexWaygood approved these changes

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL