FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-104050: Annotate Argument Clinic return converters by erlend-aasland · Pull Request #104706 · python/cpython · GitHub

/ cpython Public

gh-104050: Annotate Argument Clinic return converters - #104706

Merged
erlend-aasland merged 4 commits into
python:mainfrom
erlend-aasland:clinic/return-converters
May 21, 2023
ConversationCommits (4)ChecksFiles changed
Merged

gh-104050: Annotate Argument Clinic return converters#104706
erlend-aasland merged 4 commits into
python:mainfrom
erlend-aasland:clinic/return-converters

Conversation

erlend-aasland commented May 20, 2023 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Contributor

bedevere-bot mentioned this pull request May 20, 2023
Closed
AlexWaygood requested changes May 21, 2023
View reviewed changes
Comment thread Tools/clinic/clinic.py Outdated
Comment thread Tools/clinic/clinic.py Outdated

bedevere-bot commented May 21, 2023

Copy link
Copy Markdown

When you're done making the requested changes, leave the comment: I have made the requested changes; please review again.

AlexWaygood reviewed May 21, 2023
View reviewed changes

AlexWaygood left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Looks good other than one other small point -- feel free to merge once that's resolved!

Comment thread Tools/clinic/clinic.py Outdated
Update Tools/clinic/clinic.py
61d6bb0 
Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
erlend-aasland enabled auto-merge (squash) May 21, 2023 19:56
erlend-aasland merged commit c482e9a into python:main May 21, 2023
erlend-aasland deleted the clinic/return-converters branch May 21, 2023 20:24
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

AlexWaygood AlexWaygood approved these changes

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL