gh-100238: Vendor distutils for peg_generator - #104744
Closed
lysnikolaou wants to merge 2 commits into
Closed
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
Is there a reason we can't use setuptools via pip install rather than bringing back all this code we just removed? |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
|
Not really. I opened this in a hurry to give @Yhg1s the option to unskip test_peg_generator before beta1, since the associated issue was marked as a release blocker. Since the consensus is that it's not, I'll take the time to port this to setuptools instead. |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This puts all of distutils (except for the tests) under Tools and uses that both in the c-analyzer and the peg-generator. Stripping all the unnecessary parts of distutils should be done after b1 is released.