FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Update Windows library names for the Python version bump by Eclips4 · Pull Request #104755 · python/cpython · GitHub

  1. python
  2. cpython

Repository navigation

Update Windows library names for the Python version bump - #104755

Merged
Yhg1s merged 5 commits into
python:mainfrom
Eclips4:fix_old_version
May 22, 2023
ConversationCommits (5)ChecksFiles changed
Merged

Update Windows library names for the Python version bump#104755
Yhg1s merged 5 commits into
python:mainfrom
Eclips4:fix_old_version

Conversation

Eclips4 commented May 22, 2023

Copy link
Copy Markdown
Member

Seems that's somehow missed

Eclips4 requested a review from a team as a code owner May 22, 2023 19:39

Eclips4 commented May 22, 2023

Copy link
Copy Markdown
Member Author

cc @Yhg1s

zooba reviewed May 22, 2023
View reviewed changes

zooba left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

pyconfig.h changes look good to me. I think the configure changes are fine, but I so rarely touch that script that someone else should check it too.

arhadthedev commented May 22, 2023

Copy link
Copy Markdown
Member

Probably, automation of these changes should also be added into https://github.com/python/release-tools.

Eclips4 commented May 22, 2023

Copy link
Copy Markdown
Member Author

Also, there's a problem with test_enum, but this should be a seperate issue/PR

Eclips4 changed the title Fix old version Fix old version and some stuff May 22, 2023
Yhg1s changed the title Fix old version and some stuff Update Windows library names for the Python version bump May 22, 2023

Yhg1s commented May 22, 2023

Copy link
Copy Markdown
Member

The configure script is being taken care of in #104757, so that can be dropped from this PR.

Eclips4 commented May 22, 2023

Copy link
Copy Markdown
Member Author

The configure script is being taken care of in #104757, so that can be dropped from this PR.

Done!

Yhg1s mentioned this pull request May 22, 2023
Closed
Yhg1s merged commit 4ded2c5 into python:main May 22, 2023
Eclips4 deleted the fix_old_version branch June 7, 2023 20:30
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

zooba zooba left review comments
erlend-aasland Awaiting requested review from erlend-aasland
corona10 Awaiting requested review from corona10

Assignees

No one assigned

Labels

skip issue skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

Back | FazBrowse Home | New Git URL